mozilla-iam / auth0-custom-lock

Front-end for the newly refreshed auth0 “Lock” interface: the New Login Experience (NLX)
Mozilla Public License 2.0
8 stars 15 forks source link

Deployed infosec-dev CodeBuild project has branch filter of `master` which isn't captured in code #253

Open gene1wood opened 5 years ago

gene1wood commented 5 years ago

How is the branch filter of master set on the AWS CodeBuild project? It looks like it's not set in the CloudFormation template and isn't even supported in CloudFormation.

If this is done manually, can we document this or create a Lambda function to provision it, or switch from CloudFormation to terraform or bash?

gene1wood commented 5 years ago

Andrew confirms that the branch filter was setup manually

gene1wood commented 5 years ago

Also, this part of the CloudFormation template will overrite the manual branch filter settings and the github webhook (which is changed to just push) if applied/updated.

Maybe we take this binding out entirely to avoid this and do the whole thing manually