search

mozilla-iam / auth0-deploy

Rules and hosted pages (lock) used for the Auth0 instances of Mozilla.
Mozilla Public License 2.0
7 stars 22 forks source link

Remove hris_is_staff references from auth0-deploy. #426

Closed gcoxmoz closed 1 year ago

gcoxmoz commented 1 year ago

This is a speculative item, and I also don't trust myself to PR this correctly.

In https://github.com/mozilla-iam/sso-dashboard-configuration/pull/564 we got rid of all SSO rules that used hris_is_staff.

But this repo still has a rules/HRIS-is-staff.js (and a .json and associated tests) which sets hris_is_staff (unneeded), and says "This fix is no longer needed when CIS PersonAPI v2 is present" (that seems to be true?), making that rule unnecessary. There's also a rules/hris-is-staff overrides.js (and a .json and associated tests), where the json says the rule is not enabled, it says the override is not needed anymore, and all its users are commented out. So I think this can go away too.

This is in service of beginning to remove the need for the _HRData blob passed in from LDAP.

gcoxmoz commented 1 year ago

@dividehex is handling this in IAM-1151 / IAM-1152 , closing this issue as redundant.