search

mozilla-iam / cis

Home of Mozilla IAM change integration service repository.
Mozilla Public License 2.0
10 stars 27 forks source link

fix leeway for token expiration #500

Closed fiji-flo closed 4 years ago

fiji-flo commented 4 years ago

worked on my travis … https://travis-ci.com/github/fiji-flo/cis/builds/164447122

april commented 4 years ago

This looks good to me, the only thing I might add is that since expired is only used inside this module, maybe the default leeway should be 910 instead of 0?

gene1wood commented 4 years ago

Travis builds are likely failing as reported in #492, not because of your changes

fiji-flo commented 4 years ago

@april I thought about making the default to 910, but I wanted this explicit in the line its used. But yeah, I get your point.