search

mozilla-iam / cis

Home of Mozilla IAM change integration service repository.
Mozilla Public License 2.0
10 stars 27 forks source link

Clarifying the version of jq required in the PersonAPI docs #516

Closed gene1wood closed 4 years ago

april commented 4 years ago

Does it not work for you? I would think that any version of jq would work.

april commented 4 years ago

Looking at it, I think any version of jq since 2015 (1.5?) should probably work. I'm not really sure that's worth noting.

gene1wood commented 4 years ago

Check the link to the release notes in the PR that shows when the walk feature was added in 1.6. It's not present prior to 1.6 and so the command doesn't work in jq 1.5.

april commented 4 years ago

Ahh, you’re right, looks like 1.6. Still, that’s a pretty old release.

On Jul 20, 2020, at 9:40 PM, Gene Wood notifications@github.com wrote:

 Check the link to the release notes in the PR that shows when the walk feature was added in 1.6. It's not present prior to 1.6 and so the command doesn't work.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

gene1wood commented 4 years ago

1.5 is what's available to my OS and I encountered errors using the code in the doc and had to troubleshoot the error message about the walk feature not working to find changelogs to determine that a specific version of jq is needed, I figured I'd help the next person who encounters the problem by clarifying what version of jq is needed.

april commented 4 years ago

Huh, surprising! Sure, looks good to me then. And upgrade your jq, it's worth it. :)