search

mozilla-iam / cis

Home of Mozilla IAM change integration service repository.
Mozilla Public License 2.0
10 stars 27 forks source link

Fix all flake8 errors found in current code #530

Closed floatingatoll closed 3 years ago

floatingatoll commented 3 years ago

Hi, reviewers.

While fixing CI I found a stack of flake8 errors (E###) that were preventing CI from running. I've separated them out for review purposes into this PR, so that they can be checked for sanity.

I have confirmed in #531 that the new CI passes when these are incorporated. It will not pass without these fixes.

floatingatoll commented 3 years ago

Yeah. I could guess, but it’s outside of scope for CI repair.

On Tue, Jul 27, 2021 at 07:15 Brett Kochendorfer @.***> wrote:

@.**** approved this pull request.

In python-modules/cis_identity_vault/integration_tests/test_all_users.py https://github.com/mozilla-iam/cis/pull/530#discussion_r677493499:

def test_filtered_scan(benchmark):

  • get_all_by_any()

  • get_all_by_any()

huh, wonder why that's commented out

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-iam/cis/pull/530#pullrequestreview-715974586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWUDFHKGSCRCI3QZYZ3ODTZ25RTANCNFSM5AY7SAGA .