search

mozilla-iam / cis

Home of Mozilla IAM change integration service repository.
Mozilla Public License 2.0
10 stars 27 forks source link

Replace travis-ci.org with GitHub Actions #531

Closed floatingatoll closed 3 years ago

floatingatoll commented 3 years ago

The old CI system went away a week or so ago, and per team discussion and in order to unblock #528, we're going to switch this specific repository to GitHub Actions and get CI working again.

Hi, reviewers. This pull request is complicated, as in order to prove that I've repaired the CI system, I also need to incorporate several changes to both the Dockerfile and the CIS code itself.

In this PR, please review only the one unique commit in this PR, 44c79a2, which is not present in any other pull request; it simply removes the Travis CI config and adds the GitHub Actions config. The final push of this pull request will contain only that one unique commit; everything else below is temporarily included from the following pull requests, to demonstrate (as seen below) that CI passes once it's all put together; it's all general repair work that isn't specific to Travis CI or GitHub Actions:

floatingatoll commented 3 years ago

Aha, that explains something. Yes, I imagine we do. Thanks!

On Thu, Jul 22, 2021 at 07:54 Brett Kochendorfer @.***> wrote:

@.**** commented on this pull request.

Looking at d2a559e https://github.com/mozilla-iam/cis/commit/d2a559e619341a9cdfb55b7370af57d1ddbb55f0 looks good to me. One question as I'm not sure if that is how travis worked

In .github/workflows/make-test.yml https://github.com/mozilla-iam/cis/pull/531#discussion_r674877615:

@@ -0,0 +1,17 @@ +name: make-test + +on: [push]

Do we want this on pull_request too?

on: [push, pull_request]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-iam/cis/pull/531#pullrequestreview-712888953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWUDENAPRH2C4MFUPWSXDTZAWLDANCNFSM5AZAGBLA .

floatingatoll commented 3 years ago

Alright, I applied the final reviewed commit onto master by itself, using git push to prevent GitHub from stripping the signatures. Two more PRs to go and we'll have green CI again.