search

mozilla-iam / cis

Home of Mozilla IAM change integration service repository.
Mozilla Public License 2.0
10 stars 27 forks source link

Dockerfile repairs and optimizations for CI #534

Closed floatingatoll closed 3 years ago

floatingatoll commented 3 years ago

Hi, reviewers.

These commits were relevant as part of fixing CI for #531, and I've pulled them out separately so that they can be reviewed more easily.

I've already confirmed in #531 that the new CI passes when these changes are incorporated.

floatingatoll commented 3 years ago

I'll proceed with landing these since CI passes with them incorporated in #531 and they're safe to proceed independent of the rest of the work. Commits are signed and GitHub affirms verified.

floatingatoll commented 3 years ago

Note that GitHub managed to wreck the signatures when merging to the repository somehow, even though everything was set up for a zero-modification merge. The repo disallows force pushes, so @gene1wood if you'd like to comment on which repair path I need to take for the commitsigs, I'm certainly interested to hear about it. I don't quite know what to do myself and the repo let me merge them, but I definitely would like to try and adhere to whatever the policy is!