Closed flamingspaz closed 7 years ago
@flamingspaz i approved but didnt merge yet - im wondering:
would this work for your configuration, if we had a location = / {...} with all the cruft, then an additional custom.conf
for the proxy_pass
location?
This would ensure all reqs have the correct HTTPS redirect / harder to mess up custom configs and disable https by mistake for example
from irc/slack chat:
s/custom.conf/bypass_proxy.conf/ is probably the best solution to make things clear
also: can comment out the CSP header (though if u dont ill do it) since its more of an example, but can break some apps "by default"
in fact, i just did it except for the CSP comment ;p
@yousef just looking for your review of my review then ill merge
r+
Moving it to a different file allows us to add/mount our own custom configuration.