mozilla-iam / mozilla.oidc.accessproxy

Stand-alone OIDC Access Proxy
Mozilla Public License 2.0
12 stars 10 forks source link

Move custom nginx config to a different file #2

Closed flamingspaz closed 7 years ago

flamingspaz commented 7 years ago

Moving it to a different file allows us to add/mount our own custom configuration.

gdestuynder commented 7 years ago

@flamingspaz i approved but didnt merge yet - im wondering: would this work for your configuration, if we had a location = / {...} with all the cruft, then an additional custom.conf for the proxy_pass location?

This would ensure all reqs have the correct HTTPS redirect / harder to mess up custom configs and disable https by mistake for example

gdestuynder commented 7 years ago

from irc/slack chat:

s/custom.conf/bypass_proxy.conf/ is probably the best solution to make things clear

also: can comment out the CSP header (though if u dont ill do it) since its more of an example, but can break some apps "by default"

gdestuynder commented 7 years ago

in fact, i just did it except for the CSP comment ;p

gdestuynder commented 7 years ago

@yousef just looking for your review of my review then ill merge

flamingspaz commented 7 years ago

r+