Slack payload message tweak

mozilla-iam / sso-dashboard-configuration

Mozilla list of RPs and Groups for SSO-Dashboard

Mozilla Public License 2.0

12 stars 49 forks source link

Slack payload message tweak #795

Closed ctbfourone closed 2 months ago

ctbfourone commented 2 months ago

I noticed that ~env.GITHUB_ACTOR~ env.RELEASE_NAME is always ??? so I tossed that. Reordered the text fields a little, and made the values bold. And moved the workflow name to the empty text field spot.

[x] All PRs are assigned to the review team automatically.
[ ] New integrations: Legal and Security reviews confirmed. authorized_groups and Auth0 client_id are defined. If display: true, the logo's image is attached. Auth0 app's Connections enables LDAP only.

ctbfourone commented 2 months ago

I don't quite follow this , but I spotted a nitpick.

I noticed that env.GITHUB_ACTOR is always ??? so I tossed that.

You didn't toss this line, though. You tossed env.RELEASE_NAME. Doublecheck?

Doh, sorry, good catch. The commit was right, but my note was wrong (edited it above).