search

mozilla-iam / sso-dashboard

A python flask implementation of an SSO dashboard. OIDC for authentication and message bus for alert pipelines.
Mozilla Public License 2.0
37 stars 45 forks source link

"Tech 1337" name is shown for all users in sso prod #258

Open viorelaioia-zz opened 6 years ago

viorelaioia-zz commented 6 years ago

STR:

  1. Login to sso.mozilla.com
  2. Click the avatar in the top right corner

Expected: User's name from mozillians is shown.

Actual: "Tech 1337" name is shown.

user name in sso

andrewkrug commented 6 years ago

@viorelaioia good catch.

andrewkrug commented 6 years ago

Fixed in prod.

viorelaioia-zz commented 6 years ago

Now user_id is displayed instead of first name, even though I have a value set for first name in mozillians.org. @andrewkrug , can we change this field to show first name?

screen shot 2018-03-22 at 08 03 47
viorelaioia-zz commented 6 years ago

@andrewkrug , just saw the thread where you said we cannot use firstName/lastName, due to switching to OIDC conformant. Can we at least show username, instead of user_id?

andrewkrug commented 6 years ago

We only have what's available in the id_token. Which is incredibly limited. Once the LDAP publisher is in place and the data is guaranteed it's kind of a different story.

For now it will be the lowest common denominator.

ioana-chiorean commented 6 years ago

Feeling like I have many personalities lately.. but NULL was not one of them on my list :D Note: I do not have a mozillians.org account with my mozilla LDAP ( it is under an old community mail)

screenshot from 2018-03-23 10-01-27

viorelaioia-zz commented 6 years ago

This is still not fixed and it behaves differently for LDAP than for github. Tested in sso.allizom.org, which uses auth0 prod. LDAP (parsys_test@mozilla.com) first name shows NULL. (No user using that email in mozillians prod)

null

Github (moz.parsys@gmail.com) first name shows empty string, but no generic mozillians avatar. (No user using that email in mozillians prod)

github