search

mozilla-it / ctms-api

Mozilla Public License 2.0
7 stars 1 forks source link

Allow PRs from forked repositories to pass CI tests #88

Closed jwhitlock closed 3 months ago

jwhitlock commented 3 years ago

PR #86 was from a fork of this repo, and failed on the build-image step with this log:

2021-03-10T01:29:56.2407941Z ##[group]Run aws-actions/configure-aws-credentials@v1
2021-03-10T01:29:56.2408709Z with:
2021-03-10T01:29:56.2409083Z   aws-region: us-west-2
2021-03-10T01:29:56.2409466Z env:
2021-03-10T01:29:56.2409814Z   AWS_REGION: us-west-2
2021-03-10T01:29:56.2410205Z ##[endgroup]
2021-03-10T01:29:56.8217681Z ##[error]Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

The configure-aws-credentials action is using encrypted secrets as recommended:

https://github.com/mozilla-it/ctms-api/blob/f3b561b0b8d825554e3c66dcd3a1aca9f8c6d3fd/.github/workflows/build-image.yaml#L39-L47

This may be a misconfiguration of our secrets, or we may be correctly blocking secrets for a forked repo PR. In either case, a forked repo PR should be able to pass CI.

┆Issue is synchronized with this Jira Task

jwhitlock commented 3 years ago

A side effect of building the final image is running the linting steps. Linting should still run on pull requests from forked repositories.

grahamalama commented 3 months ago

We no longer build the image in this repo, so I'll close this issue.