search

mozilla-l10n / styleguides

Localization styleguides
https://mozilla-l10n.github.io/styleguides
Creative Commons Attribution 4.0 International
27 stars 73 forks source link

Store deploy key in Travis CI variable #95

Closed MikkCZ closed 6 years ago

MikkCZ commented 6 years ago

Storing the ssh key in a variable directly is a simpler way and allows easier setup (see the readme file) and faster key rotation if needed. There should be no security implications compared to the current solution. The secret variables are not accessible for pull requests, and the current solution uses them too.

MikkCZ commented 6 years ago

For anyone wondering why is the base64 part, it's because of escaping and newlines in the variable.

MikkCZ commented 6 years ago

Actually Travis CI supports deploys to GitHub pages on its own. https://docs.travis-ci.com/user/deployment/pages/

flodolo commented 6 years ago

Replaced by #97