search

mozilla-lockwise / lockbox-extension

Experimental Firefox extension for login management experiences, not being actively developed
Mozilla Public License 2.0
127 stars 26 forks source link

Create shared eslint config for projects and modules #102

Open devinreams opened 6 years ago

devinreams commented 6 years ago

A suggestion from @pdehaan at https://github.com/mozilla-lockbox/lockbox-datastore/pull/34#pullrequestreview-64613424 to consider:

a custom eslint-config-lockbox and/or eslint-plugin-lockbox so you can share ESLint configs between repos for cross repo consistency

pdehaan commented 6 years ago

If somebody with GitHub powers can create an empty mozilla-lockbox/eslint-plugin-lockbox, I can take a stab at creating a shared ESLint config (if this is something you want to pursue).

devinreams commented 6 years ago

I think it's something we'll want. There is project-specific stuff we'd still need to consider including/excluding. For example "browser" stuff and a11y linitng would not be necessary for the datastore...

https://github.com/mozilla-lockbox/eslint-plugin-mozilla-lockbox

pdehaan commented 6 years ago

Initial PR for shared plugin rules at https://github.com/mozilla-lockbox/eslint-plugin-mozilla-lockbox/pull/1. It was working locally for me, but I had to do a bit of package.json hackery to install from my GitHub PR branch since it hasn't been published to npm, so it may take a bit of fiddling once we get the PR merged and published.