search

mozilla-lockwise / lockbox-extension

Experimental Firefox extension for login management experiences, not being actively developed
Mozilla Public License 2.0
127 stars 26 forks source link

Improve Redux logic/organization #297

Open jimporter opened 7 years ago

jimporter commented 7 years ago

I'm not happy with how we decide to show modals for the management UI. The biggest issue is that our Redux action creators depend on our state, which means that state depends on actions and actions depend on state. It also relies on creating actions that essentially describe the state transition rather than the user action that occurred (Redux style prefers the latter).

This is something we really ought to fix before we start relying on it too heavily, but it's going to take a bit of research to figure out what the best way to do it is. Maybe redux-saga would be better than redux-thunk...?

jimporter commented 6 years ago

We should also subdivide our action creators/reducers like https://github.com/erikras/ducks-modular-redux