search

mozilla-lockwise / lockbox-extension

Experimental Firefox extension for login management experiences, not being actively developed
Mozilla Public License 2.0
127 stars 26 forks source link

Refactor CSS to use common variables #319

Open jimporter opened 6 years ago

jimporter commented 6 years ago

It'd be nice if we used CSS variables for our colors. This will also probably require that we add CSS minification to remove duplicate definitions of said variables.

For minification, we can use https://github.com/NMFR/optimize-css-assets-webpack-plugin maybe?

devinreams commented 6 years ago

It'd be nice if we used CSS variables for our colors

@jimporter Agreed. What do you think about using the variables approach documented here? https://github.com/css-modules/css-modules/blob/master/docs/values-variables.md

pdehaan commented 6 years ago

How about using Sass? That way we'd get improved nesting support and other stuff for "free".

jimporter commented 6 years ago

I don't think we get much out of SASS that we don't already get from modularized CSS.