search

mozilla-lockwise / lockbox-extension

Experimental Firefox extension for login management experiences, not being actively developed
Mozilla Public License 2.0
127 stars 26 forks source link

Entry details screenshot needs to be updated in onboarding flow #413

Open pdehaan opened 6 years ago

pdehaan commented 6 years ago

This is what the edit Entry Details page looks like in master branch currently:

lockbox_entries_2

Here's what the screenshot (moz-extension://{addon-id}/images/intro-step-3.png) looks like during onboarding w/ zero entries:

lockbox_entries_-_onboarding

https://github.com/mozilla-lockbox/lockbox-extension/blob/9eefdcbfc15b9deaaf9d1760a3abc91c7c5926af/src/webextension/list/manage/components/intro-page.js#L46

Note the following differences:

  1. "Site name" vs "Entry name".
  2. Position of "Copy" buttons relative to the content.
  3. Appearance of password bullets.
pdehaan commented 6 years ago

Also minor differences on the first screenshot:

SCREENSHOT ACTUAL
  1. "Username" placeholder is different.
  2. "Password" field is missing "Show" toggle button.
  3. "Notes" label is missing "(optional)" suffix.
jimporter commented 6 years ago

Since this is just a temporary UI (we'll eventually have an intro on Test Pilot or something), I'm not sure how much time we want to spend keeping this in sync... @changecourse?