mozilla-lockwise / lockbox-extension

Experimental Firefox extension for login management experiences, not being actively developed
Mozilla Public License 2.0
127 stars 26 forks source link

Verified account window does not close if email is in same browser #581

Open rbillings opened 6 years ago

rbillings commented 6 years ago

The Your Account is Verified popup window displays and does not close if the user confirms their email from the same browser as the LB extension. This does not repro when the email account is not in the same browser as lockbox.

1) open LB with new profile: npm run run -- -p Profile --no-copy 2) open Gmail in same browser window, in another tab, log into account 3) Lockbox create account flow 4) go to Gmail tab, click "activate account' link

expected: Lockbox tab displays "account verified" message, or popup window with verification displays and then closes actual: Lockbox opens popup window with "account verified" message, window does not close by itself

linuxwolf commented 6 years ago

@rbillings

The Your Account is Verified popup window displays and does not close if the user confirms their email from the same browser as the LB extension.

Is this the same tab of the same window, or a different tab in the same window? I assume the latter given the steps, but need to confirm.

  1. Lockbox create account flow Is this initiated from the welcome page (i.e., "Welcome to Lockbox') or the full editor page (i.e., "Lockbox Entries")?

I am having difficulty reproducing this, but it can take some time (e.g., several seconds) before the popup closes.

actual: Lockbox opens popup window with "account verified" message, window does not close by itself

In my testing, the webmail application opened a (yet another) new browser window with "Account Veriied" that never closed. The original FxA sign-in popup triggered by Lockbox did close (i.e., there were only two browser windows open for me once the full flow completed).

linuxwolf commented 6 years ago

CC @rfk

rbillings commented 6 years ago

1) The email and lockbox tabs are within the same window 2) I clicked "Get started" from the welcome page, followed by "Create Account" on the Home page 3) My test results match yours: the original FxA sign-in popup closes, a new "account verified" browser window opens that never closes and is on top of the Lockbox window.

rfk commented 6 years ago

"browser window opens "

To be clear, do you mean it actually opens a whole new popup window, rather than just a new tab in the same window as your webmail client?

linuxwolf commented 6 years ago

To be clear, do you mean it actually opens a whole new popup window, rather than just a new tab in the same window as your webmail client?

@rfk that was the experience in my own testing. For me, I tested from two separate GSuites with the same result -- did not try a completely separate webmail application.

rbillings commented 6 years ago

@rfk yes, it opens a whole new popup window