mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
623 stars 104 forks source link

On first launch Lockwise is stuck and the back button is not working after a home button interrupt #1099

Open abodea opened 4 years ago

abodea commented 4 years ago

See comments below

Precondition

After using the latest release 3.2.0 (Build 5522), perform a sync, edit few logins and after that install over 3.2.0 version the new one 3.3.0 or update it from google play.

Steps to reproduce

  1. Launch Lockwise.
  2. Login with valid credentials.
  3. Access any account from the entries list.
  4. Perform a home button interrupt(lockwise is added to background).
  5. Resume Lockwise.
  6. Tap on the back button from the account screen in order to reach the entries list.

    Expected behavior

    The back button works as expected and the user is redirected to the entries list.

    Actual behavior

    The back button is not working and the user is stuck there.

    Device & build information

    • Device: Google Pixel 3a XL(Android 10)
    • Build version: 3.3.0 (Build 5660)

      Notes

      Note that this issue can be reproduced on a fresh install and with an update from a previous version. As I described on the Actual behavior from above, after resuming Lockwise, by tapping the device back button, the account screen is displayed once again, it looks like after a home button interrupt, the screen is duplicated. By tapping once on the device back button, then the Lockwise back button is working correctly, but without this step the user is stuck.

Attachments:

Video 1 Video 2 Video 3 longLogcat.txt FullLogcat+Update_From_3.2.0_to_3.3.0.txt

This is a GIF from a fresh install of v3.3.0 (Build 5658) ezgif-6-166e219420e4

abodea commented 4 years ago

Please also, note the following:

Section Home button interrupt performed? Reproducible?
Account screen Yes
Account screen(delete/edit menu open) Yes
Account screen in edit mode Yes
Account screen(Delete this login screen displayed) Yes
Account Yes
FAQ Yes
Provide Feedback Yes
Settings Yes
Auto-Lock dialog opened Yes
Learn more from Settings section Yes
Account screen No
Account screen(delete/edit menu open) No
Account screen in edit mode No
Account screen(Delete this login screen displayed) No
Account No
FAQ No
Provide Feedback No
Settings No
Auto-Lock dialog opened No
Learn more from Settings section No

Please note that for sections like FAQ, Provide Feedback, Settings, Account sometimes when tapping back a white screen with Lockwise is displayed and after tapping back again, the correct section is displayed.

jhugman commented 4 years ago

Cannot reproduce on Pixel 3, from either master or the release-v3.3.0. None of videos or GIF show steps I can reproduce.

Is this intermittent, or 100% reproducible from the state that the app is in?

I haven't been able to get the app into a state where reproducing this is possible.

abodea commented 4 years ago

Hello, I retested this issue with a clean profile using Google Pixel 3a XL(Android 10) and Samsung Galaxy S10+(Android 9) with v3.0.0 from Play Store and I was able to reproduce it on both devices following the steps from the description.

abodea commented 4 years ago

I re-tested this issue on the latest build 3.3.0 (Build 5784) for more details please check the following:

After further investigations on the latest build, I was able to reproduce this issue only at first launch and after a restart, the issue is no longer reproducible. I was able to reproduce this issue with any device, I made a new video for this.

Device Device Reproducible at first launch? Reproducible after restart?
Google Pixel 3a XL 10 Yes No
Samsung Galaxy S10+ 9 Yes No
Google Pixel 3 9 Yes No
Huawei Mate 20 Lite 9 Yes No
Samsung Galaxy S8+ 8.1.1 Yes No
Samsung Galaxy Note 9 8 Yes No
Samsung Galaxy S7 7 Yes No

@jhugman @eliserichards I would consider this issue now an edge case because it is reproducible only at first launch but it can still be a possible issue for real users but we can let it open until we will fix it. Based on my comment I will remove the QA-needed.