search

mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
623 stars 104 forks source link

#1195: add ability to delete user telemetry data #1196

Closed eliserichards closed 4 years ago

eliserichards commented 4 years ago

Fixes #1195

Testing and Review Notes

Screenshots or Videos

To Do

eliserichards commented 4 years ago

@travis79, how is this looking to you? (feel free to tag @mdroettboom or whoever has bandwidth to take a look)

travis79 commented 4 years ago

FYI, there are tools available for testing the metrics you are adding, and if you wanted to add test coverage, then these docs may be useful.

travis79 commented 4 years ago

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?

This data will be used to delete legacy telemetry data associated with the id when they opt out of telemetry.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

This allows us to comply with user privacy regulations.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?

Existing legacy telemetry does not currently have the ability to send a deletion request ping and this was the easiest way to get that information.

4) Can current instrumentation answer these questions?

N/A

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Legacy telemetry client id Category 1 https://github.com/mozilla-lockwise/lockwise-android/pull/1196

6) How long will this data be collected? Choose one of the following:

For the lifetime of the application, owned by the Lockwise team.

7) What populations will you measure?

8) If this data collection is default on, what is the opt-out mechanism for users?

Lockwise provides a preference for telemetry labeled "Send Usage Data" that will be used as the opt-out mechanism.

9) Please provide a general description of how you will analyze this data.

This will be analyzed with the normal Glean methods such as GUD and GLAM.

10) Where do you intend to share the results of your analysis?

Internally with Mozilla, through normal Glean reporting methods.

Flagging @chutten for datareview?

chutten commented 4 years ago

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Glean so is documented in its definitions file metrics.yaml and the autodocs.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Glean so can be controlled through the app preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No one was identified on the Data Review Request. All permanent collections are required to have an individual responsible for them. Please identify someone before landing and ensure their email is included (in addition to any lists) in the metric's notification_emails.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical. (client_id is a highly-identifiable piece of information but in this usage is a technical detail as it is being sent in order to be deleted.)

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No. But it does include one old one.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

Result: datareview+, pending the identification of a responsible individual.

travis79 commented 4 years ago

No one was identified on the Data Review Request. All permanent collections are required to have an individual responsible for them. Please identify someone before landing and ensure their email is included (in addition to any lists) in the metric's notification_emails.

@eliserichards can you provide an individual contributor email address that will be responsible for this and add it to the notification_emails per @chutten's request?