search

mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
623 stars 104 forks source link

Disable "null" toast #1219

Closed aero31aero closed 4 years ago

aero31aero commented 4 years ago

Steps to reproduce

Expected behavior

Nothing happens

Actual behavior

A toast appears with text "null".

Device & build information

Another person could reproduce it at https://www.reddit.com/r/android_beta/comments/hs0d6k/null_toast/fyqnoox

Attachments:

GlenMerlin commented 4 years ago

Can reproduce

Pixel 4 Android 11 stable build version 4.0.1

only happens when lockwise is the currently selected autofill app

best apps I've found to test with consistent results are Signal Private Messenger 4.70.5 Firefox Android 80.1.2 Instagram (Direct Messaging) 157.0.0.37.120

Note: the toast itself is coming from android system but due to it only happening when lockwise is the default I'm led to believe something is erroring with android 11

caeci11ius commented 4 years ago

Confirmed occurs with lockwise as autofill provider, does not occur when provider changed to google. Problem comes back when lockwise selected again.

AMonreale commented 4 years ago

Same thing here, Pixel 3a with Android 11. Authy seems the more consistent app showing this toast.

nsghub commented 4 years ago

Same here on Pixel 3a and Android 11. Pretty anoying.

rickhall commented 4 years ago

Same issue for me on my Pixel 4XL...I'll have to check on my Pixel 4a later. For me, I can easily reproduce it by going into the Messages app and entering any conversation. Every time I enter any conversation, I get a "null" popup message.

teopb commented 4 years ago

Happens on pixel 4a updated to android 11 today.

marcomg commented 4 years ago

Some issue with a pixel 3a with Android 11!

oniGino commented 4 years ago

Confirmed on pixel 2 w/android 11

blitz commented 4 years ago

Same here with a Pixel 3a and Android 11.

@eliserichards Do you someone who can take a look?

LRomuloux commented 4 years ago

same issue. Pixel 2 Android 11.

JoeCactus commented 4 years ago

Replicated on Pixel 3a XL, 4.02 not yet available on Play Store for me.

blitz commented 4 years ago

@Baron-Severin @eliserichards Thank you so much for fixing this! :rocket:

rahan-crao commented 3 years ago

Is it possible to publish a version with this fix on the Play Store ? It's been more than two weeks the fix is committed...

oniGino commented 3 years ago

Mozilla has pretty much abandoned this app and notes and others, who knows when they will get to pushing this

rahan-crao commented 3 years ago

I just made an APK because I can't wait anymore: https://drive.google.com/file/d/1pu96SQ8QkqRqMNU1p_ERdraiB-lZrXNT/view?usp=sharing

Disclaimer:

GlenMerlin commented 3 years ago

This is taking mozilla so long to just push it too the playstore I decided to switch over to bitwarden its a shame

constructor-s commented 3 years ago

I just made an APK because I can't wait anymore: https://drive.google.com/file/d/1pu96SQ8QkqRqMNU1p_ERdraiB-lZrXNT/view?usp=sharing

Disclaimer:

  • use it at your own risk
  • you must uninstall Lockwise before installing the APK
  • you will not receive Lockwise update anymore from the Play Store since it is an external APK

Sorry if I missed the build instructions but @rahan-crao how did you build it? Just clone in Android Studio and build the release version? No additional modification/external files/libraries required?

rahan-crao commented 3 years ago

Sorry if I missed the build instructions but @rahan-crao how did you build it? Just clone in Android Studio and build the release version? No additional modification/external files/libraries required?

Android SDK 28 must be installed on your computer. I launched gradlew.bat which downloaded all dependencies. After the I used Android Studio to build the APK. Don't update the gradle plugin with Android Studio, otherwise you will not be able to build Lockwise any more.

caeci11ius commented 3 years ago

Just a suggestion while everyone is waiting for this to roll out.

Just disable lockwise autofill in the auto-fill service page of settings (you can search, or find it under system > languages and input). The Firefox internal autofill still works fine for websites, so you'll only lose autofill in apps. You can manually copy password from lockwise for these. Sure, if you're regularly logging in and out of apps this will be annoying, but if you're like me, most of your logins will be to websites and unaffected. At least you'll be rid of the annoying toast popup in the meantime, and it's easy to turn it back on when the update finally rolls out.

Cubox commented 3 years ago

It has been a month since the issue was fixed in this repo. There is no APK available through the releases section of this repo, nor any updates through the Play Store.

@eliserichards Is there any reason for this delay? All the Android 11 users of Lockwise would love to get the updated code. Thanks in advance

Cubox commented 3 years ago

I have sent an email to the lockwise support email.

We’ve received your support request and opened a ticket (11818). We are processing your request.

I hope that'll help get someone on the team to just build a release

rickhall commented 3 years ago

The sad part is, LockWise is one of the more useful and important things Mozilla has released in a while. If it dies, I will be pretty bummed. Apparently, the writing is on the wall.

ghost commented 3 years ago

The app was last updated June 29th 2020 according to the playstore. Is it completely abandoned?

kabel commented 3 years ago

Sure, it stinks if Moz abandons releases to the play store, but we're lucky enough that it's open source and we have awesome community members like @rahan-crao who are willing to publish test binary builds that have the fix.

Patience as always, lest you're one of the lucky ones with a Mozilla insider or support contract. Just keep adding your +1's and we'll keep the spam notifications down while still showing our interest in seeing this fixed and released.

Cubox commented 3 years ago

I have sent a tweet to the Mozilla Twitter account, and sent messages through Matrix (chat.mozilla.org) on the general channel and the lockwise channel, to raise awareness of the need for a new release. EDIT: Also sent tweets to Mozilla Corp CEO, Mozilla Foundation President & Executive Director, Executive VP, VP of Firefox Desktop

Webbeh commented 3 years ago

I compiled a version of it with the null toast problem fixed.

Since I had to self sign this Apk, it is blocked by play protect (they don't know my certificate). You will have to do a full install (remove the previous version) for it to install.

Edit: wait a minute, uploaded the wrong apk...

Cubox commented 3 years ago

When the application signature changes key, the application won't update in place and requires a reinstall. That's normal and not due to Play Protect

Also, when you generate those APKs, make sure they are the release mode, and not the debug one. That requires the creation of a keystore, which is not needed for debug variants. If on login you see something like "USE TEST DATA" in red at the bottom of the app, that's debug mode.

Webbeh commented 3 years ago

I know don't worry, I've been using the app for a few weeks, just uploaded the wrong version of the apk. 

Webbeh commented 3 years ago

https://geeq.ch/index.php/s/FbRft7AEydgLAMc

Let me insist that this is self signed and will be reported as untrusted source, and you will need to uninstall the current Lockwise first.

st3fan commented 3 years ago

I just filed the following issue to get 4.0.2 out of the door. https://github.com/mozilla-lockwise/lockwise-android/issues/1239