mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android

https://mozilla-lockwise.github.io/lockwise-android/

Mozilla Public License 2.0

623 stars 104 forks source link

Consistently see a "null" toast message in new Android #1237

Closed ghost closed 3 years ago

ghost commented 3 years ago

Steps to reproduce

Install Lockwise on a Pixel 4 running Android 11 (other models may be affected)

Expected behavior

Whenever the gboard keyboard is opened, a "null" toast message does NOT appear

Actual behavior

Whenever the gboard keyboard is opened, a "null" toast message DOES appear

Screenshot_20201101-085506

Device & build information

Screenshot_20201101-084849

Notes

It seems to only affect certain apps, or perhaps certain situations. I can consistently reproduce it when using the Android Messages app.

GOinfo-Ltd commented 3 years ago

1224

1225

GOinfo-Ltd commented 3 years ago

https://github.com/mozilla-lockwise/lockwise-android/issues/1219#issuecomment-727525094 Self-signed APK including the fix.

Cubox commented 3 years ago

This issue should be closed as duplicate of #1219

jrmuizel commented 3 years ago

It looks like #1219 has still not shipped though.

abodea commented 3 years ago

Verified as fixed on the latest version 4.0.2 with Google Pixel 4 XL (Android 11). Note that I tried with many apps but I couldn't reproduce it anymore. I tried with the Android messages app, but everything worked as expected and no Null toast was displayed. @ajjensen13 can you also, take a look, please? Tested with Instagram, Latest Fenix Beta, Nightly, RC, Android messages app, Facebook, Twitter, and many other apps.

ghost commented 3 years ago

Confirmed I'm running version 4.0.2 and I cannot reproduce the issue. Thanks everyone who worked on this fix!

abodea commented 3 years ago

Thank you for the confirmation @ajjensen13!!