search

mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
622 stars 104 forks source link

Implement a filter action for list filtering #130

Open sashei opened 6 years ago

sashei commented 6 years ago

As referenced in https://github.com/mozilla-lockbox/lockbox-android/pull/109#discussion_r222990197

This issue will create a TextFilterAction in case we would like to use or track filtering behavior out of the FilterPresenter and listen for it elsewhere.

Instead of filtering happening in-place within the Presenter, it should go through the rest of the Flux flow, and have additional triggers/monitors (e.g., telemetry).

linuxwolf commented 6 years ago

@sashei can you expand on what this is? Is it still needed?

sashei commented 6 years ago

@linuxwolf I've added to the description; I think this an improvement to the current implementation but not a necessity.