mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
623 stars 104 forks source link

"Most recently used" doesn't register copy actions #661

Open bsurd opened 5 years ago

bsurd commented 5 years ago

Steps to reproduce

  1. Have a few logins saved and sorted alphabetically. (eg. ff account, facebook & twitter)
  2. Open FF and go to Twitter and sign in using Lockbox autofill option.
  3. Go back to Lockbox, tap on "All entries" and select recently used.

Expected behavior

Twitter is moved to the top of the list as it's the last autofill option used.

Actual behavior

The list remains ordered in alphabetical order

Device and build information

Notes

devinreams commented 5 years ago

Interesting, thanks for the report @bsurd.

I can tell that the copy actions do "touch" the item and pop it to the top of the "Recent" list.

So I think this is more narrowly any "fill from autofill" actions may not be "touching" the entry to make it appear used/accessed recently.

My own steps to reproduce:

  1. Open Lockbox
  2. Sort by Recent
  3. Tap into the 3rd item (detail)
  4. Tap the "copy password" button in the detail view
  5. Go back and observe the 3rd item is no win the 1st slot in the list ✅
  6. Open Duolingo app, go to login
  7. Search for the 2nd item in the "Recent" listing
  8. Fill that matching item into the sign in field
  9. Open Lockbox app and observe the Recent order is the same ❌
mhammond commented 4 years ago

There are actually 2 bugs here: