search

mozilla-lockwise / lockwise-android

Firefox's Lockwise app for Android
https://mozilla-lockwise.github.io/lockwise-android/
Mozilla Public License 2.0
623 stars 104 forks source link

Proper Attribution of Dependencies (license notices) #706

Open linuxwolf opened 5 years ago

linuxwolf commented 5 years ago

Information on the dependencies and their copyrights/licenses should be present in the software.

At the least, this repository should include the following information on the dependencies:

There is discussion that it may need to be presentable to users of this software in some form.

Design

Description: The new menu item requires a new header of "About" at the base of the list

Settings Section InVision: https://mozilla.invisionapp.com/share/3SN35UHWJDX#/309979885_Settings Zeplin: https://zpl.io/awYA3LK

Licenses Webview Invision: https://mozilla.invisionapp.com/share/3SN35UHWJDX#/384822495_Licenses Zeplin: https://zpl.io/a39WGq8

Note: There needs to be a responsive webview URL (location and build TBD) for housing all licenses, as Firefox has done for their licenses.

References

BMO 1548663 BMO 1561735

devinreams commented 5 years ago

Blocked by upstream dependencies noting their dependencies too (A-C, A-S).

Assumption is we mimic the UX of the other Firefox apps, and needs to be available offline (in the app itself when distributed). Can mitigate in the meantime by adding to our FAQ page as well.

rfk commented 5 years ago

Blocked by upstream dependencies noting their dependencies too (A-C, A-S).

For A-S, we now include a list of dependencies in the repo here:

https://github.com/mozilla/application-services/blob/master/megazords/lockbox/DEPENDENCIES.md

It will be updated automatically if our set of dependencies changes (or rather, CI will prevent landing dependency updates without regenerating this file).

changecourse commented 4 years ago

@sandysage @ddurst I've updated the description above and have provided everything (I think) for us to begin development. Please review and prioritize accordingly :)

It's also worth mentioning that the location, URL structure, and building of the responsive mobile page still need to be completed for this effort.

ddurst commented 4 years ago

LGTM

sandysage commented 4 years ago

Do we have a provided Firefox place for hosting Lockwise licenses? Who do we need to work with to get that set up? Or can we just host these on lockwise.firefox.com for now?

@ddurst @rfk can one of y'all point me in the right direction on this?

changecourse commented 4 years ago

Please also plan and document the parity approach for iOS too: https://github.com/mozilla-lockwise/lockwise-ios/issues/1093

marniepw commented 4 years ago

@sandysage sounds like we'd want to host on SUMO? Or do we want to host on github.io? @ddurst is talking to Security about github.io and should have additional details next week.

ddurst commented 4 years ago

Update from BMO 1587941 is that we can put updates.json on the moz.org site. From BMO 1555743 (via @devinreams), the documentation is the only limiting factor for github.io -- and if those are moving to SUMO, then we should proceed with moving the docs to SUMO, removing them from github.io, moving updates.json to moz.org, and then disabling the github.io site entirely.