search

mozilla-lockwise / lockwise-ios

Firefox's Lockwise app for iOS
https://mozilla-lockwise.github.io/lockwise-ios/
Mozilla Public License 2.0
245 stars 46 forks source link

autofilll is broken since 1.6.0 #1070

Open heubergen opened 5 years ago

heubergen commented 5 years ago

Steps to reproduce

Install app Login Activate the app as the only autofill service Open a login site (e.g. auth.netatmo.com) with Safari Click on the blue autofill button with your login on it OR Click on the key symbol and then choose the login from the list

Expected behavior

Login information are filled out

Actual behavior

Nothing happens

Device & build information

heubergen commented 4 years ago

@devinreams Just tried it with iOS 13.2 but I'm still experiencing the issue. I activated the auto fill functionality after the update, started a fresh Safari browser and tested it.

pinchies commented 4 years ago

I'm noticing no improvement with iOS 13.2. In fact, if anything it's worse, as I'm noticing what appears to be graphic glitches when the Lockwise interface loads at first, before focus is given to the login search box.

OneSpecialPeg commented 4 years ago

I am persevering with Lockwise as I really would like to see this be a success but the functionality has been poor on IOS for a long time. I really hope there can be some steps forward soon, I use 1Password for work and the workflow is so much better. Fingers crossed.

PS. Happy to offer some testing/QA help if needed.

cschultzzz commented 4 years ago

Too bad no progress or news is promoted on this issue. I finally decided to give up and jump to Bitwarden. Fingers crossed for all others - LockWise really had me!

tanmaster commented 4 years ago

I just found out about lockwise today as i was researching password managers but my initial excitement blew off when I experienced this issue... Looking forward to a fix for this :-)

ddurst commented 4 years ago

This issue is next up after our 1.7.0 release (which should be released this week).

Due to the intermittent repeatability of this, anyone who can regularly reproduce this, please include as detailed steps to reproduce (STR) as you can. We can't confirm an ETA for a fix until we can reproduce (or otherwise identify) the cause of this.

pinchies commented 4 years ago

It happens 100% of the time in safari for me. It also happens consistently in some apps that use web views. Im happy to help any way that would be useful, e.g teamviewer + iPhone screen streaming to Mac?

tanmaster commented 4 years ago

For now, 1.7.0 seems to have fixed the issue for me. It is working as expected, I logged in using Lockwise to comment this.

dhruvkb commented 4 years ago

@tanmaster unfortunately, 1.7.0 did not fix it for me.

pinchies commented 4 years ago

Lockwise 1.7.0 did not fix for me, nor did iOS 13.2.3.

ddurst commented 4 years ago

For now, 1.7.0 seems to have fixed the issue for me. It is working as expected, I logged in using Lockwise to comment this.

@tanmaster Can you give us details on your device? We're digging into this in our current sprint.

tanmaster commented 4 years ago

Sure. iPhone 8 Plus on iOS 13.3 Public Beta (17C5046a), Lockwise 1.7.0, iCloud Keychain disabled.

I was having the same issues as the users above me had described (pressing the big blue button would do nothing and even though my username appeared above the keyboard, pressing it did also do nothing), but after the update they seem to be resolved. I logged in successfully on 4 different services and it seems to be working fine within apps too.

hdnshare commented 4 years ago

I still have this bug, Very annoying. Glad that I'm not the only one have this bug. iPhone 7 iOS 12.2 Lockwise 1.7.0

I didn't find this topic 3 days ago, so I created bug report #1145

hdnshare commented 4 years ago

In version 1.7.0, the bug still there, but I see that there is improvement:

  1. Open safari > Private mode > go to a website > login page.
  2. Auto fill button doesn’t work.
  3. Tap “Lockwise...”, wait till Lockwise popup, then tap “cancel”
  4. Now tap Auto fill button, wait 1 second (it doesn’t auto fill immediately), and it works. Now the auto fill button work.
  5. I lock the iPhone, then unlock the iPhone, now the auto fill button doesn't work again, do step 1, 2 to make it work again.
pinchies commented 4 years ago

I can confirm the exact same behaviour on my device too. After cancelling I can autofill correctly.

https://youtu.be/9tyOWFB_5ic

hdnshare commented 4 years ago

Hi Lockwise dev, here is my bug reproduce steps, hope you can reproduce it if you haven't successfully reproduced the bug:

  1. Open ProtonVPN, connect VPN to Japan.
  2. Open Safari > private mode.
  3. Go to Facebook > tap the big blue auto fill button > bug: auto fill button not work.
ddurst commented 4 years ago

I've been testing this with:

And I am completely unable to reproduce it. For those who see this all the time, I'm wondering if something else can be involved (though offhand I can't imagine what, but I am not a frontline engineer)? Regardless, because the reports follow no pattern (in iOS version, iPhone/iPad models, etc), perhaps some of you (like @pinchies and @dhruvkb and @hdnshare) could share any other settings -- no matter how tangential? I'm specifically looking for the most basic, non-fancy login experiences, or the most widely-used, that can reproduce this.

Thanks.

pinchies commented 4 years ago

I repro' this on earlier this year on a setup as new device, immediately after signing into lockwise. Can we do any diagnostics on my phone? I can screen share my device with you easily enough, and we could chat over skype or similar.

kaylagalway commented 4 years ago

@hdnshare or @pinchies - When you go to your iPhone Settings -> Privacy -> Analytics & Improvements -> Analytics Data - The events should be in alphabetical order. Do you see any logs starting with "Firefox Lockbox"?

pinchies commented 4 years ago

@kaylagalway Hi, just checked, not listed. iOS 13.3, App version 1.7.1. Send Usage Data enabled.

But... hold onto your hats...

.....the bug is gone on my device!! 🥇 Seems to be working fine in Safari!!!

kaylagalway commented 4 years ago

@pinchies nice! Do you know if that started after the 13.3 iOS update or the 1.7.1 Lockwise update? Or unclear? @hdnshare are you on 13.3?

natolh commented 4 years ago

Same here, I don't know why but the bug is gone on iPhone 5S running iOS 12.4.4 and Lockwise 1.7.1. And I can't say when it has started to be better.

pinchies commented 4 years ago

I think I spoke too soon. I rebooted and the problem came back. I think what has changed is the cancel trick to get things working is staying fixed for a lot longer than it used to. My guess is iOS 13.3 as I think that was the most recent change for me? But not sure.

hdnshare commented 4 years ago

@kaylagalway In privacy analytics, I found “Firefox Lockbox-2019-10-24-20...”, do you want me to send it? The log is pretty long. I’m using iOS 12.2

hdnshare commented 4 years ago

@kaylagalway I think the bug has something to do with internet. Here is my test.

  1. Safari > private mode > Twitter login page. Auto fill button doesn’t work.
  2. Disable wifi. Back to Twitter login page. Auto fill button works and it fills immediately, no delay.
  3. Now enable wifi, auto fill button backs to broken state.
dhruvkb commented 4 years ago

I'm on iOS 13.3 running Lockwise 1.7.1. This trick https://github.com/mozilla-lockwise/lockwise-ios/issues/1070#issuecomment-558916953 works for me too.

ghost commented 4 years ago

I tried to reproduce the steps on Twitter.com and the first time it worked (with WiFi on). The I signed out to try again and it completely stoped working. I tried to turn WiFi off and on, killed and reopened Lockwise but nothing made it work again. Not even in github when I had to sign in to make this comment.

Here is part of the log that was generated during this tests:

Exception Type: EXC_CRASH (SIGKILL) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Reason: Namespace SPRINGBOARD, Code 0x8badf00d Termination Description: SPRINGBOARD, process-exit watchdog transgression: application:3051 exhausted real (wall clock) time allowance of 5.00 seconds | ProcessVisibility: Background | ProcessState: Running | WatchdogEvent: process-exit | WatchdogVisibility: Background | WatchdogCPUStatistics: ( | "Elapsed total CPU time (seconds): 4.830 (user 4.830, system 0.000), 16% CPU", | "Elapsed application CPU time (seconds): 0.080, 0% CPU" | ) Triggered by Thread: 0

hdnshare commented 4 years ago

@matheusfernal “

I tried to turn WiFi off and on, killed and reopened Lockwise but nothing made it work again. “

Try using the auto fill button when offline (wifi off, not when on), it should fill immediately. Or you can try the cancel trick.

ghost commented 4 years ago

@hdnshare You’re right. With internet turned off (I used airplane mode) it works immediately.

heubergen commented 4 years ago

Airplane mode and autofill works again.

kaylagalway commented 4 years ago

Okay that's interesting... @matheusfernal would it be possible for you to send that crash log to me? @hdnshare could you send yours as well? Are you both on the most recent version of Lockwise and iOS? - kgalway at mozilla dot com

hdnshare commented 4 years ago

@kaylagalway Here the log: https://drive.google.com/file/d/1SFdZmLGjZjaJK9VFgreMYoEUqxj8XADy/view?usp=drivesdk

I'm currently using Lockwise 1.7.1, iOS 12.2

Did you try my VPN reproduce steps I mentioned earlier?

dhruvkb commented 4 years ago

In addition to the cancel and retry trick, switching to airplane mode works for me as well! @kaylagalway I searched in Privacy > Analytics but there are none for Lockwise.

pinchies commented 4 years ago

https://youtu.be/uzHL8bAD0Fs Wifi off “fixes” things temporarily for me as well.

ghost commented 4 years ago

@kaylagalway I just sent 2 crash logs to you. The one from yesterday and other with a different kind of exception. I’m using Lockwise version 1.7.1.

kaylagalway commented 4 years ago

The airplane mode fix actually helped me isolate the section of code this issue is coming from. @matheusfernal I received those logs, thank you.

I will be quiet in response on here over the holidays but will update on any findings in the new year. Thank you all for your help!

modern-hermit commented 4 years ago

I’m sorry but this is ridiculous. How can I trust all my passwords and personal security to an app whose developers took over 6 months to start working on a solution for the main reason the app exists (password security and accessibility)?

We’re still waiting.

OneSpecialPeg commented 4 years ago

Good luck with this project but personally I have moved to 1Password.

dhruvkb commented 4 years ago

I will be quiet in response on here over the holidays but will update on any findings in the new year. Thank you all for your help!

@kaylagalway, we're one fortnight into the new year, any updates on the resolution of this issue?

ddurst commented 4 years ago

This is still being worked on, and I would remind everyone to be respectful. I understand this has been going on a while and that it's frustrating -- it's frustrating for us as well. The team will resolve it as quickly as we can.

pinchies commented 4 years ago

Edit: probably not the right place for my comments. More frequent updates would be appreciated.

ddurst commented 4 years ago

@pinchies Thank you. I appreciate it.

I think you'll find that everyone on our team agrees with your sentiments. Unfortunately, there's only so much we can do. We'll try to update more on the progress of things.

kaylagalway commented 4 years ago

@pinchies Would you be interested in testing a debug build with logging since you are able to consistently reproduce the issue? If you are, my email is kgalway at mozilla dot com - send me a message and I will get you set up.

hdnshare commented 4 years ago

@kaylagalway : today it got worse, the Lockwise app keep crashing - can’t even open, here is the log file: https://drive.google.com/file/d/1mvCnyupvNC5fN2x5PvbqxFO9TQk3Xkq-/view?usp=drivesdk

hdnshare commented 4 years ago

I'm just saying, but if it's hopeless to fix, I suggest roll back to the version that works. I don't know why you update, but update from working to not-working is a bad update.

heubergen commented 4 years ago

No chance @hdnshare because that would mean to put some effort into this issue and clearly nobody cares about it anyway. (I asked for a 1.6.0 build in my first comment eight months ago...)

pinchies commented 4 years ago

I am not confident the actual cause of the issue has yet been identified, however I was told this on the 20th feb after I sent some log files in:

Hey Samuel, [...] Your logs actually confirm the issue we thought we were having, which is that we aren't erroring, but it seems that sync is taking too long to complete.  [...] this is currently the top priority. Thank you for all of your help! Best, Kayla

I can only hope that they are working diligently on solving this issue at this point. 😶

hdnshare commented 4 years ago

[...] it seems that sync is taking too long to complete.

I guess they tried to fix a bug that didn’t sync the new password from PC, thus they made the app sync new password when autofill, thus cause this bug. If what I guess is right, I suggest the app has a sync button in the app that only sync when we manually press it (guide user to do that). And the auto-fill feature should have nothing to do with internet (currently you can see that the autofill button works when Airplane mode is on, then I see that they have some design problem with the app)

pinchies commented 4 years ago

@kaylagalway Is there any chance we could get a frank and transparently honest status update?

hdnshare commented 4 years ago

It just gets worse and worse, now it doesn't even open, totally unusable, here is the demo video: https://vimeo.com/402797259 Demo: iPhone Firefox Lockwise doesn't even open Device: iPhone 7 iOS: 12.2 Lockwise: 1.7.2 (since I can't open the app, I check the Lockwise's version in App Store, and see that Lockwise is in the latest version)