search

mozilla-lockwise / lockwise-ios

Firefox's Lockwise app for iOS
https://mozilla-lockwise.github.io/lockwise-ios/
Mozilla Public License 2.0
245 stars 46 forks source link

recently used doesn't work #416

Open sashei opened 6 years ago

sashei commented 6 years ago

steps to reproduce:

expected: item with copied username appears at the top actual: not necessarily

devinreams commented 6 years ago

@sashei To better understand this: you mean the "A-Z" sorter on list view does not have actual recency data behind it to actually sort on?

sashei commented 6 years ago

@devinreams yes, I just haven't seen it behave as expected. haven't dug into the root cause yet so I don't know if it's a data problem or just something that's broken in another way.

devinreams commented 6 years ago

I've been using the app with "real" data on the TestFlight build and it appears to sort recently for me.

Alpha order for me starts with: 192.168.***, accounts.firefox.com, accounts.google.com...

Recent order then changes to: ally.com, alaskaair.com, southwest.com (I did banking and looked at flights the other day)

So... it seems to be working as expected for me. But perhaps a more rigorous test run / definition is needed.

joewalker commented 6 years ago

FWIW, I'm using Lockbox synced with my live data, and I'm fairly sure the "Recent" sort order is not correct. For example: mozilla.auth0.com, ..., digg.com, ..., google.com Obviously I've not used digg in the past 100 years. Presumably we should have most recent usage first?

devinreams commented 6 years ago

I'm fairly sure the "Recent" sort order is not correct.

Keeping in mind the "recency" is per-device (not going to match your desktop or Firefox mobile used timestamp)...

joewalker commented 6 years ago

I'm fairly sure the "Recent" sort order is not correct.

Keeping in mind the "recency" is per-device (not going to match your desktop or Firefox mobile used timestamp)...

So where is the sort order correct?

devinreams commented 6 years ago

So where is the sort order correct?

I think it's correct, it's just also confusing. I think what we see in Lockbox is:

  1. recent item I copied a password from recently (has recency data)
  2. recent item I added a few days ago (has recency data)
  3. no activity item (no data)
  4. no activity item (no data)
  5. ...

And it's not obvious where the "recency" items stop and the "everything else" items begin... does that seem to match what others are seeing and feeling? I agree its weird in early-use but now my "recent data" is starting to fill in and the sorting looks "more useful" to me.

joewalker commented 6 years ago

I guess for the people that sign up and connect to Sync, when they first start they have no recency data so the list is confusing. Maybe we should hide the sort-order dropdown for cases where anything other than A-Z is not going to make sense?