Add top bar for Join Firefox

mozilla-lockwise / mozilla-lockwise.github.io

Take your passwords everywhere

https://lockwise.firefox.com

Mozilla Public License 2.0

46 stars 11 forks source link

Add top bar for Join Firefox #123

Closed devinreams closed 5 years ago

devinreams commented 5 years ago

Screen Shot 2019-05-31 at 07 58 55

[x] add banner to home page (only) with tracking link
[x] fix bug with flex re-calculating the Firefox logo instead of keeping it 24px on small responsive layout
[x] change from a fixed position over the page to actually block content pushing the page content down
[x] make sure "Join Firefox" wraps together onto new line Fixes #130

tldr on how to test locally, see readme for more details:

clone this repo
check out this branch
run the bundle exec jekyll serve commands

changecourse commented 5 years ago

If possible, I’d prefer for the top bar to sit above the main content, rather than over it, based on spacing overlaps in the screenshot posted above.

devinreams commented 5 years ago

@changecourse OK. I quickly tried that but broke all kinds of layout based on how the page is built with flex. Will play a bit more with it but that was the quickest implementation to get to staged.

devinreams commented 5 years ago

Tagging @johngruen in case he can help out since this is his website 🏅 and much smarter at CSS than I am. Thanks for the extra eyes 🎩

devinreams commented 5 years ago

Here's the latest based on @johngruen's speedy work ⚡️

Screen Shot 2019-05-31 at 07 58 55