mozilla-lockwise / mozilla-lockwise.github.io

Take your passwords everywhere
https://lockwise.firefox.com
Mozilla Public License 2.0
46 stars 11 forks source link

Change Add-on Install Link based on Requesting Platform #127

Closed linuxwolf closed 5 years ago

linuxwolf commented 5 years ago

Fixes #124 Connected to #125

This changes the install button based on the user's current browser:

jaredhirsch commented 5 years ago

@linuxwolf Also, it's probably fine, but there are some weird version strings like "67pre3" that you should double-check won't do strange things when parseInt'd: https://developer.mozilla.org/en-US/docs/Mozilla/Toolkit_version_format

linuxwolf commented 5 years ago

That, and moving to an external script actually broke the links.

Will have to think this through a bit more ...

jaredhirsch commented 5 years ago

ah yeah, I was wondering if the double-mustaches were going to get templated or not if they were added after initial page render. I would guess that we'd need to specify the complete link, or insert a client-side templating library to render those URLs dynamically

linuxwolf commented 5 years ago

ah yeah, I was wondering if the double-mustaches were going to get templated or not if they were added after initial page render. I would guess that we'd need to specify the complete link, or insert a client-side templating library to render those URLs dynamically

I was missing the frontmatter "secret sauce". Now links are correct (again).