mozilla-magnet / magnet-adaptor-sched

Magnet adaptor for Sched venue urls
0 stars 3 forks source link

Regression - The height is not adapted to the content of the tile #31

Closed isabelrios closed 8 years ago

isabelrios commented 8 years ago

This happens with latest android build. If the sched venue only have one or two events, the tile is shown in a square bigger than its content. Please see image below. screenshot

arcturus commented 8 years ago

@isabelrios was this happening without the last commit that @wilsonpage added yesterday about height?

isabelrios commented 8 years ago

@arcturus I downloaded today nightly build and it is where I saw it, so I guess that build has that commit.

samgiles commented 8 years ago

Filed https://github.com/mozilla-magnet/magnet-client/issues/142 - this should make figuring out cases like this easier.

On Thu, 9 Jun 2016 11:04 isabelrios, notifications@github.com wrote:

@arcturus https://github.com/arcturus I downloaded today nightly build and it is where I saw it, so I guess that build has that commit.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-magnet/magnet-adaptor-sched/issues/31#issuecomment-224852530, or mute the thread https://github.com/notifications/unsubscribe/AAzSjqlEyMXqM15PRgLwbX-S6ENmHXULks5qJ-U6gaJpZM4Ixvzf .

isabelrios commented 8 years ago

I should have commented this before, but opened the bug here because this is only happening to me with sched tiles, the others are correctly sized.

wilsonpage commented 8 years ago

closes by 491f21ce07bd9f8ada7751ee3eb16611c1f7c877

wilsonpage commented 8 years ago

The reasons this was happening is because we were telling the tile to be 300x300 size via the oembed.json. Then once the webview content was measured it was correctly returning 300 as a document, even though the tile content is only 200px tall.

I removed the width/height properties from the oembed.json so that now the height is based purely on then content measurement.

isabelrios commented 8 years ago

Cool! this is fine now :)