mozilla-magnet / magnet-adaptor-sched

Magnet adaptor for Sched venue urls
0 stars 3 forks source link

Opening meetings details does not work correctly #4

Closed isabelrios closed 8 years ago

isabelrios commented 8 years ago

I tried with this: https://mozillalondonallhands2016.sched.org/venue/Monarch+Suite/Metropole+West+Wing Being modified as: https://tengam.org/adaptors/sched/?url=https://mozillalondonallhands2016.sched.org/venue/Monarch+Suite/Metropole+West+Wing Here if I click on embed and then on the event I can see its details: https://mozillalondonallhands2016.sched.org/event/72lY/london-all-hands-welcome-reception

From the app, I tap on the event name 1- Nothing seems to happen(the link is not selected nor the background text changes),

2- Sometimes tapping on the event name several times and afer a while a page is shown but cannot be open to interact with it openeventdetails

isabelrios commented 8 years ago

With latest build, opening the link from the tile details works. But, would like to confirm if the link shown is correct as the experience is different than on the web site. For example with this venue: https://mozillalondonallhands2016.sched.org/venue/Monarch+Suite/Metropole+West+Wing

Converted as: https://tengam.org/adaptors/sched/?url=https://mozillalondonallhands2016.sched.org/venue/Monarch+Suite/Metropole+West+Wing

If you click on the event 'London All Hands Welcome Reception' On the web you see this: https://mozillalondonallhands2016.sched.org/event/72lY/london-all-hands-welcome-reception

And from the app: First view: event details 1

Then if you tap on Schedule, you see more events, not the details of the event from which the link was launched: event details 2

And finally if you tap again on the event name 'London All Hands Welcome Reception' (in the previous screenshot is now shown but is below the latest event name), you can see its details as shown in the web site: event details 3

Also, if you click on Speakers, a blank page is shown: event details speakers

isabelrios commented 8 years ago

With latest commit (aa45a02) this issue is more evident again. It is not easy to tap on the event name and get the browser open. You have to tap several times and not always is open.

wilsonpage commented 8 years ago

So I think the blank Sched page is a bug in Sched when loading a desktop URL into a mobile client.

From where I see it we have two options:

  1. We navigate all clicks to the 'Venue' page and not the specific event (simple)
  2. We transform desktop session URLs into mobile session URLs to avoid broken redirect (more complex, could break)

I thought about the idea of scraping the mobile site instead of the desktop, but it seems the mobile site is rendered clientside. I did notice that the API key is included in the initial payload, so we could have the option of extracting that, and using the JSON API unofficially; although this is a little naughty.

wilsonpage commented 8 years ago

If we favour Option 2 we just need to make sure that we have the session id to hand. The mobile session URLs look as follows:

https://mozillalondonallhands2016.sched.org/mobile/#session:58a086aa3b7369e810e5f4c19f14d6ae

wilsonpage commented 8 years ago

@arcturus is this fixed?

arcturus commented 8 years ago

Yes this has been hot fixed yesterday.