search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
19 stars 11 forks source link

Notifications - "1 items near you" would be better "1 item near you" #178

Closed isabelrios closed 8 years ago

isabelrios commented 8 years ago

When there is only one beacon around the notification says "1 items near you" it is just the items word which is in plural. Not a critial issue but nice to change if possible :)

wilsonpage commented 8 years ago

I think this is nice wording that avoids the inaccurate numbering issue.

Perhaps a variation on this:

Magnet found websites nearby Tap to explore

isabelrios commented 8 years ago

Yeah, that could be a good option :)

arcturus commented 8 years ago

@isabelrios I've just landed new notifications in ios. We got ride of the badge and we use a notification saying there ware web pages around you.

isabelrios commented 8 years ago

@wilsonpage, @arcturus is it planned to change also the android notification to show that general notification instead of the number of items found for the Simplified MVP or for future versions?

wilsonpage commented 8 years ago

Yes, this is a very easy change to make.

wilsonpage commented 8 years ago

I've included this change as part of MVP branch. The wording is now:

"Content found nearby - Tap to explore"

isabelrios commented 8 years ago

We can close this issue now since the wording is different and this issue does not apply with the current implementation.