search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
19 stars 10 forks source link

Prompt when data is disabled and there are virtual beacons #302

Open isabelrios opened 7 years ago

isabelrios commented 7 years ago

In an environment with only virtual beacons if data/wifi is off while the app is closed or in background, there is not any warning about Network problem when launching/refreshing the app.

Tested it in a place where there is virtual beacon. App was closed and data off. 1-Launched the app 2-The app was open, Scanning... 3-After a while it showed nothing found

There was not any warning shown and no tile was discovered.

oteo commented 7 years ago

Table created to show all the possible test cases.

Although the summary, as Isabel explains, is that when there are only virtual beacons around, it seems that the connectivity check is not done and the user is not prompted in case the Data is disabled

So far, when we had only physical beacons, if Data and BT were disabled, the user was first asked to activate the BT and later (after turning it up) he was prompted about the "Network error".

Apart of fixing the bug, we were wondering that now that we have physical and virtual beacons,if it would make more sense prompting about the network failure first (as it's the critical one) and later, ask to activate the BT, @dbialer @djabberwocky wdyt?

wilsonpage commented 7 years ago

We can use the ReactNative Netinfo module to check and listen for changes in connectivity. I suggest we follow the convention of displaying a 'Device offline' banner whenever we don't have connectivity.