search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
17 stars 10 forks source link

Settings - Remove old Items is not working properly #307

Open isabelrios opened 7 years ago

isabelrios commented 7 years ago

For physical beacons -Android: Steps 1-From magnet desktop broadcast url 1 2- Open mangnet and see the tile 3- Without closing magnet, change the url broadcasted from magnet desktop to url 2 4- Check in magnet that tile 2 is shown 5- Wait till tile 1 disappears Actual behavior Tile 1 does not disappears

-iOS It works ok for physical beacons.

Virtual beacons -Android: Steps 1-You are in a location with a virtual beacon 1 2-Open the app and see the tile, do not close the app 3-Using Fake GPS app change your location to where beacon 2 is 4-Bring magnet back to foreground and check that beacon 2 is shown Actual behaviour Virtual beacon 1 tile is never removed

-iOS: Steps 1-You are in a location with a virtual beacon 1 2-Open the app and see the tile, do not close the app 3-Using xCode change your location to where beacon 2 is 4-On magnet app check that beacon 2 is shown Actual behaviour Virtual beacon 1 tile is never removed

isabelrios commented 7 years ago

I would set this as P1 in order to fix it or hide the feature till it is working, but we know in advance this is not working so IMHO it is better not to launch with this in its current status

wilsonpage commented 7 years ago

Let's make these visible to Debug build only, so we can test the features without exposing broken stuff to users.

On Tue, 15 Nov 2016 09:55 isabelrios, notifications@github.com wrote:

I would set this as P1 in order to fix it or hide the feature till it is working, but we know in advance this is not working so IMHO it is better not to launch with this in its current status

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-magnet/magnet-client/issues/307#issuecomment-260596921, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-ShxuoNyEeP99CngqOXEJoLNCjJ81Xks5q-YF5gaJpZM4Kp2E1 .

isabelrios commented 7 years ago

Sounds good, thanks!

isabelrios commented 7 years ago

@arcturus, @wilsonpage Just open issue #337 for that