search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
19 stars 10 forks source link

Settings - Show distance is not working for virtual beacons #308

Open isabelrios opened 8 years ago

isabelrios commented 8 years ago

Either it should be shown or this settings should be hidden till this is supported. This issue would depend on issue #304

isabelrios commented 8 years ago

I would set this as P1 in order to have it for virtual beacons too or hide the feature till it is working, but we know in advance this is not working so IMHO it is better not to launch with this in its current status

wilsonpage commented 8 years ago

Let's make these visible to Debug build only, so we can test the features without exposing broken stuff to users.

On Tue, 15 Nov 2016 09:56 isabelrios, notifications@github.com wrote:

I would set this as P1 in order to have it for virtual beacons too or hide the feature till it is working, but we know in advance this is not working so IMHO it is better not to launch with this in its current status

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-magnet/magnet-client/issues/308#issuecomment-260597229, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-Sh9ZY5du1KszOY3bK6O3HGh0s7ZTQks5q-YHEgaJpZM4Kp2UR .

isabelrios commented 8 years ago

Sounds good, thanks!

arcturus commented 8 years ago

@wilsonpage do we have a bug to make those settings just debug only?

isabelrios commented 8 years ago

@arcturus, @wilsonpage Just open issue #337 for that