Read the latitude and longitude from the scanner - Githubissues

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS

Mozilla Public License 2.0

17 stars 10 forks source link

Read the latitude and longitude from the scanner #324

Closed gmarty closed 7 years ago

gmarty commented 7 years ago

See also:

Please don't land now.

arcturus commented 7 years ago

We will need to be careful when the user leaves this view open in the background and then come back.

We could do all that work in a follow up.

arcturus commented 7 years ago

@gmarty is this ready to merge? @wilsonpage anything else you want to add?

gmarty commented 7 years ago

I'm working on integrating this patch properly into Redux as suggested by @wilsonpage. Let's wait until this is ready.

gmarty commented 7 years ago

This is ready to review now!

arcturus commented 7 years ago

Compute distance returns kms and we are displaying meters in the ui, so we see 0 for mostly all virtual beacons.

arcturus commented 7 years ago

Please check travis is red for this PR :S

arcturus commented 7 years ago

Looking good for me, r+ once comments are addressed.

gmarty commented 7 years ago

I fixed the failing test. @wilsonpage please a final review before landing.

wilsonpage commented 7 years ago

Needs a rebase.

wilsonpage commented 7 years ago

r+

Few nits to address
start/stop watching location code looks brittle, needs some basic checks in place. Plus IMO if it holds state (eg. listeners/watchers/clients) it should be a class. If you're confident this is solid enough, we can make this a followup.