search

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS
Mozilla Public License 2.0
17 stars 10 forks source link

If the request store is empty, generate an empty Object response #332

Closed samgiles closed 7 years ago

samgiles commented 7 years ago

Closes #330

@wilsonpage r?

wilsonpage commented 7 years ago

This is still throwing. I think empty JSON objects resolve to null somewhere in the pipeline. Either we cope with null on the client, or find a way to send an empty object.

samgiles commented 7 years ago

@wilsonpage I couldn't reproduce the null issue. I've added a fallback in the JavaScript.

wilsonpage commented 7 years ago

@samgiles I can reproduce on emulator and on device. Have you tried uninstalling the app and re-installing fresh?

samgiles commented 7 years ago

r? I got to the bottom of it.

Since Wilson's jet set, @arcturus?

arcturus commented 7 years ago

r+ once travis is green

wilsonpage commented 7 years ago

@samgiles can you rebase this?