Deep linking (closes #331)

wilsonpage commented 7 years ago

@arcturus r? (ping-pong sorry)

arcturus commented 7 years ago

Follow ups:

Make a service that returns both metadata + beacon data. Outside of metadata server, remove the api in js land that do the mixing (https://github.com/mozilla-magnet/magnet-services/issues/30)
Batch requests about objects (https://github.com/mozilla-magnet/magnet-client/issues/347).
onLost logic for ios scanners. (https://github.com/mozilla-magnet/magnet-scanner-ios/issues/13)
Cache of items, at some point clear old items, but when the items get complicated. Now it's not a problem (https://github.com/mozilla-magnet/magnet-client/issues/346)
Rename files to match class name.
Calculate distance on the client from strength or lat lon, but we won't update the model that often, on the native side we should send a power mashed up (https://github.com/mozilla-magnet/magnet-scanner-ios/issues/12, https://github.com/mozilla-magnet/magnet-scanner-android/issues/25)
When launching the app directly from deep linking dont show the list of items (https://github.com/mozilla-magnet/magnet-client/issues/348)

arcturus commented 7 years ago

@wilsonpage after rebasing to latest master (it has a patch from @samgiles for react-native version) it does kind of work in iphone.

It at least tryies to load the view, it loads the basic, and then the app dies cause an exception in the new postArray method, need to debug more to understand whats going on.

arcturus commented 7 years ago

More feedback about what's going on.

It's important to take into account the environment where I am, surronded by beacons that we constantly receive, so I have hundreds of calls to app render scene home in a matter of 10 seconds. Either that or we are constantly triggering model change, and also calling fetchItemIfNeeded even if it's going to end soon, we still have an enormous number of calls to that function.

That is making the animation to open the item to be very slow and to compite for resources. When we load an item that is in the cache everything seems to work ok.

arcturus commented 7 years ago

Yes, I can confirm that in the simulator without so many update cause of btle beacons everything works way smoother.

We can consider this like an aggressive environment, but we should think on adding some throttling to that update coming from BLE.

wilsonpage commented 7 years ago

@arcturus:

Fixed perf issue caused by transitions being hammered by react re-render
Tested deep links working on real ios device
Ready to land

arcturus commented 7 years ago

Shiiiiip it once travis is green :)

mozilla-magnet / magnet-client

Deep linking (closes #331) #338