Deep linking to item view when notification is clicked

mozilla-magnet / magnet-client

A nearby content discovery client for Android & iOS

Mozilla Public License 2.0

17 stars 10 forks source link

Deep linking to item view when notification is clicked #355

Closed arcturus closed 7 years ago

arcturus commented 7 years ago

@wilsonpage r?

Before we were just handling the click on the custom actions, but not the normal notification.

This will end fixing #189

wilsonpage commented 7 years ago

The custom protocol looks wrong, it's missing the //
Shouldn't we also be deep linking for < iOS-10?

wilsonpage commented 7 years ago

r+ after those comments addressed

arcturus commented 7 years ago

Shouldn't we also be deep linking for < iOS-10?

Yes, thanks for the remind, it's pretty easy to do in the AppDelegate. Good catch!

arcturus commented 7 years ago

Oh I just realised, for ios9 we say 'Content nearby' we don't show specific notifications for poi, so with that behaviour makes sense to send the user to the list.

As well we don't know what the user wants to see, as that notification could mean that you found several things.