search

mozilla-magnet / magnet-metadata-service

A service that returns metadata for given URLs
Other
8 stars 10 forks source link

Adding a few more ESLint rules and fixes #30

Closed pdehaan closed 8 years ago

pdehaan commented 8 years ago

Nothing too fun or interesting, just a few more boring rules to enforce missing semi-colons and blank lines at end of files. Most of these are warnings, but we can dial them up to errors in future PRs if we want to fail Travis-CI on ESLint violations.

The real fun [and disruption] starts if we choose to turn on the no-var and prefer-const rules.

wilsonpage commented 8 years ago

I'm a fan of all these chances except "curly". I like single-line if :)

arcturus commented 8 years ago

I'm a great fan of curly :) :) (it's my java past )

wilsonpage commented 8 years ago

I'm a great fan of curly :) :) (it's my java past )

If you leave Link you can have "curly" :)

samgiles commented 8 years ago

+1 for curly. 👍 (sorry @wilsonpage)

wilsonpage commented 8 years ago

😠