search

mozilla-magnet / magnet-scanner-android

An Android library that scans for URLs around you
3 stars 6 forks source link

Should be called 'magnet-scanner-android'? #1

Closed wilsonpage closed 8 years ago

wilsonpage commented 8 years ago

If this library is only usable on Android I feel we should make it clear in the title

wilsonpage commented 8 years ago

Sorry this is a bit NITTY of me 😱

arcturus commented 8 years ago

Actually yes, as it uses android libraries.

wilsonpage commented 8 years ago

Renamed github repo. I think the classes themselves should be renamed to reflect the project name:

Scanner -> MagnetScanner

etc

arcturus commented 8 years ago

Not the repo, I agree on renaming the class Scanner but the repo name is ok, as we should have a different repo for the swift library.

wilsonpage commented 8 years ago

@arcturus you already agreed on the rename of the repo above, so that's been done. If/when we make an ios equivalent, it should be called magnet-scanner-ios not magnet-scanner-swift.

The libraries have a hard dependency on a specific platform, the language they are written in is irrelevant.

arcturus commented 8 years ago

That's totally right, and yes, more sense as I said myself, it's not pure java, it uses android classes so ...