search

mozilla-magnet / magnet-scanner-android

An Android library that scans for URLs around you
3 stars 6 forks source link

Pass the latitude and longitude to JavaScript-land #20

Closed gmarty closed 7 years ago

gmarty commented 7 years ago

See also:

I also updated the code to use the url property rather than the deprecated slug.

arcturus commented 7 years ago

This PR looks good to me, we will need to modify the magnet client too, I guess that's coming in another PR:

https://github.com/mozilla-magnet/magnet-client/blob/master/android/app/src/main/java/org/mozilla/magnet/MagnetScannerReact.java

@wilsonpage thoughts? Just thinking on the serialization method, if we should add the values or not (checking if they are null)

gmarty commented 7 years ago

Yes, the in progress JS PR is here: https://github.com/mozilla-magnet/magnet-client/pull/324

But obviously once finished it will contain all the code related to displaying the distance in the POI view.

gmarty commented 7 years ago

I addressed all the comments above. How does it look now?

wilsonpage commented 7 years ago

SHHHHHIP.IT