search

mozilla-magnet / magnet-scanner-ios

An iOS library that scans for URLs around you
Mozilla Public License 2.0
1 stars 4 forks source link

Refactoring the scanner service to offer a class for performin one si… #11

Closed arcturus closed 7 years ago

arcturus commented 7 years ago

…ngle check on location.

arcturus commented 7 years ago

@wilsonpage r?

This is a step closer to reuse the new OneShotLocation class in region detection.

arcturus commented 7 years ago

@wilsonpage this needs ❤️ so if you feel jetlagged remember this is waiting for you.

wilsonpage commented 7 years ago

To summarise this patch:

Comments:

wilsonpage commented 7 years ago

Shhiiiiii 🚢 !

arcturus commented 7 years ago

To summarise this patch:

Moves all location retrieval logic into a separate class.
Increases scan virtual beacon scan radius.
Let me know if I missed anything else :)

Comments:

Just some naming that could be made more semantic and conventional for readability.
Otherwise, nice tidy up.

You got it crystal clear. The reason for separating the location logic as well is for reusing it outside of the scanner.