mozilla-mobile / FirefoxLite

Emerging Market Experiment
Mozilla Public License 2.0
282 stars 96 forks source link

The search suggestion cannot be related to top site "kapanlagi" #1865

Closed NashTung closed 3 years ago

NashTung commented 6 years ago

STR

  1. Install Rocket 2.0
  2. Launch Rocket 2.0
  3. Tap on search field
  4. Input a text "ka" but not press enter
  5. The search suggestion is "kaskus.co.id"
  6. The search suggestion cannot be related to top site "kapanlagi"

https://drive.google.com/open?id=111u6gCXpyPAyFmfGHNf0M1NMibw9JlMt

Expected result:

Actual result:

Reproduce rate: 100%

Device: Redmi 4A Rocket: 2.0.0(3585) Android: 7.1.2 Webview: 65:0.3359.126

mTwTm commented 6 years ago

I think this one's is by design. domain autocomplete is based on site popularity but there are some more factors around top-site selection. However we might want a domain list revisit.

chianger commented 6 years ago

the behavior of domain autocomplete is by design. no intention to change it at this moment.

weslyhuang commented 6 years ago

should re-check if we are talking about the same thing/symptom. Nash to add more detail.

mTwTm commented 6 years ago

FWIW, this is the list we're using to generate domain autocomplete (and priority) https://github.com/mozilla-tw/Rocket/blob/master/app/src/main/assets/domains/id

NashTung commented 6 years ago

Add video, and the other top site will be related on search suggestion

mTwTm commented 6 years ago

For the 5 search suggestions, they are provided by search providers (probably Google) and by current design we're not changing the suggestions. From your description (kaskus) I think you're referring to the domain auto-completion. As listed in https://github.com/mozilla-tw/Rocket/blob/master/app/src/main/assets/domains/id kaskus is before kapanlagi. This list is most likely compiled from Alexa top 50 We currently don't prioritize top-sites when we're doing autocomplete and from @joechengla comment yesterday offline I think this is aligned to his expectation.