search

mozilla-mobile / FirefoxLite

Emerging Market Experiment
Mozilla Public License 2.0
285 stars 98 forks source link

Wrong source in game banner #4019

Closed elin-moco closed 4 years ago

elin-moco commented 5 years ago

Describe the bug Received game name in source parameter, which should be the game partner name

Steps To Reproduce Steps to reproduce the behavior:

  1. Go to Game home
  2. Click on the first banner
  3. Go to Firebase DebugView

Expected behavior start, content_tab, null {source=FRVR}

Actual behavior start, content_tab, null {source=Dartz FRVR}

Screenshots/videos If applicable, add screenshots/videos to help explain your problem.

Device info (please complete the following information):

Reproduce rate How many times you can reproduce such issue, given the testing rounds

Additional context

benjamin-cheng commented 5 years ago

Source from API is Dartz FRVR Screen Shot 2019-10-29 at 7 49 55 PM

weslyhuang commented 5 years ago

similar to mozilla-tw/FirefoxLite#4018, per triage we need:

  1. @shsu571 @Mozillove (or @harly21) to help update data source
  2. UI adjustment (not necessary P0), @Mozillove (or @harly21) would you help put it in another ticket and decide the priority? tks.
shsu571 commented 5 years ago

@Mozillove need to give me the latest version of data

shsu571 commented 5 years ago

Already upload new data in Preview, and clarify with BI. Data is correct now.

weslyhuang commented 5 years ago

confirmed fixed and verified by BI team.