mozilla-mobile / FirefoxLite

Emerging Market Experiment
Mozilla Public License 2.0
282 stars 96 forks source link

Support Traditional Chinese for Booking.com hotel cards #4494

Closed tinahsieh closed 4 years ago

tinahsieh commented 4 years ago

Describe the bug The current hotel cards only support Simplified Chinese.

Information from Booking.com API specialist "We have 3 that can be done via api, zh-yu, zh-ch, zh-tw"

Actions

benjamin-cheng commented 4 years ago

It would show Traditional Chinese with language zh-tw https://distribution-xml.booking.com/2.5/json/hotels?city_ids=-553173&language=**zh-tw**&extras=room_info,%20payment_details,%20hotel_info,%20hotel_photos,%20hotel_facilities,%20hotel_description&rows=1

However, it would show Simplified Chinese with language zh-hant-tw https://distribution-xml.booking.com/2.5/json/hotels?city_ids=-553173&language=**zh-hant-tw**&extras=room_info,%20payment_details,%20hotel_info,%20hotel_photos,%20hotel_facilities,%20hotel_description&rows=1

So, we should manually change the zh-hant-tw to zh-tw(lower case) in booking.com APIs (both autocomplete and hotels)

Conjuror commented 4 years ago

17646