search

mozilla-mobile / FirefoxLite

Emerging Market Experiment
Mozilla Public License 2.0
282 stars 95 forks source link

Upgrade to Target SDK API Level 29 #5346

Closed st3fan closed 3 years ago

st3fan commented 3 years ago

For background information, see https://support.google.com/googleplay/android-developer/answer/9859152#targetsdk

It seems master was updated to support API Level 29 through #5314 - is it possible to move those changes to the releases_v2.6.0 branch?

st3fan commented 3 years ago

It looks like the only thing #5314 did was to increment the target_sdk through https://github.com/mozilla-mobile/FirefoxLite/commit/8b3424c8dce79de41929560b8f6e4cbf99fb6569 - no other changes were needed?

st3fan commented 3 years ago

Hmm very confusing.

Master is on 29 and that change happened August 10.

I branched releases_v2.6.0 off the release/v2.5.2 branch, from September 22nd, but it has a target_sdk of 28.

So it looks like the SDK 29 changes never shipped.

We should probably start from scratch: increment the target_sdk, see what happens both when building the product and when submitting it to the Play Store.

st3fan commented 3 years ago

@jonalmeida With the linked PR, things build and test, so maybe that is good enough? I am planning to send a build to the Play Store on Monday to find out if it detects anything that needs to be fixed. If you can think of anything, add it to this bug please.