search

mozilla-mobile / FirefoxLite

Emerging Market Experiment
Mozilla Public License 2.0
282 stars 95 forks source link

Fixes #5346 - Upgrade to Target SDK API Level 29 #5347

Closed st3fan closed 3 years ago

st3fan commented 3 years ago

This patch changes target_sdk to 29 and also pulls in https://github.com/mozilla-mobile/FirefoxLite/commit/a18eff2e597fb15e1b58f11152ddea9391d8b734 as a workaround to make RoboElectric tests work again.

jonalmeida commented 3 years ago

I think we need to make one more change with the compile SDK, but if this builds, let's land it!

I see a bunch of warningsAsErrors that we would need to fix when updating our compile SDK. Maybe let's see if we can publish a new build to the play store with just this before we try to fix those?

Most of the errors below:

``` > Task :app:compileFocusWebkitDebugKotlin FAILED e: warnings found and -Werror specified w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/FocusApplication.kt: (11, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/FocusApplication.kt: (136, 9): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/FocusApplication.kt: (136, 27): 'setDefaultValues(Context!, Int, Boolean): Unit' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/activity/EditBookmarkActivity.kt: (158, 44): Type mismatch: inferred type is MenuItem? but MenuItem was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/activity/MainActivity.kt: (476, 55): Type mismatch: inferred type is String? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/activity/MainActivity.kt: (483, 56): Type mismatch: inferred type is PinTopSiteUseCase.PinTopSiteResult? but PinTopSiteUseCase.PinTopSiteResult was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/provider/SettingProvider.kt: (15, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/provider/SettingProvider.kt: (59, 31): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/provider/SettingProvider.kt: (59, 49): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (10, 27): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (28, 34): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (38, 79): 'constructor Preference(Context!, AttributeSet!, Int)' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (39, 9): 'setter for widgetLayoutResource: Int' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (44, 60): 'constructor Preference(Context!, AttributeSet!)' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (45, 9): 'setter for widgetLayoutResource: Int' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (54, 15): 'onAttachedToActivity(): Unit' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (56, 53): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (60, 15): 'onBindView(View!): Unit' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (63, 35): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (64, 51): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (65, 49): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (66, 40): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (67, 42): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (68, 65): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (68, 151): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (69, 49): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (69, 120): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (70, 54): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (71, 51): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/focus/widget/DefaultBrowserPreference.kt: (77, 55): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (4, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (64, 26): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (64, 44): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (88, 26): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (88, 44): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (96, 26): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/abtesting/LocalAbTesting.kt: (96, 44): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (4, 27): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (19, 5): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (19, 42): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (23, 5): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (72, 36): 'Preference' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (74, 27): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/Extention.kt: (76, 27): 'getter for context: Context!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntNewsRemoteDataSource.kt: (202, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntNewsRemoteDataSource.kt: (206, 25): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntNewsRemoteDataSource.kt: (208, 28): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (153, 29): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (154, 25): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (156, 32): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (179, 29): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (180, 25): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (182, 28): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/dailyhunt/DailyHuntSettingsRemoteDataSource.kt: (185, 32): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/newspoint/NewsPointNewsRemoteDataSource.kt: (87, 17): Condition 'id == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/newspoint/NewsPointNewsRemoteDataSource.kt: (87, 31): Condition 'title == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/newspoint/NewsPointNewsRemoteDataSource.kt: (87, 48): Condition 'link == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/newspoint/NewsPointNewsRemoteDataSource.kt: (87, 64): Condition 'publishDate == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/newspoint/NewsPointNewsRemoteDataSource.kt: (92, 31): Unsafe use of a nullable receiver of type Date? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/rss/RssNewsRemoteDataSource.kt: (88, 66): Unnecessary safe call on a non-null receiver of type String! w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/rss/RssNewsRemoteDataSource.kt: (97, 17): Condition 'title == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/rss/RssNewsRemoteDataSource.kt: (97, 34): Condition 'link == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/rss/RssNewsRemoteDataSource.kt: (97, 50): Condition 'publishDate == null' is always 'false' w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/news/data/rss/RssNewsRemoteDataSource.kt: (101, 17): Unsafe use of a nullable receiver of type Date? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (25, 34): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (26, 49): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (124, 35): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (125, 39): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (127, 36): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (129, 39): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (130, 41): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (136, 64): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (143, 35): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (144, 40): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (153, 35): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (154, 32): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (156, 40): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (163, 36): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (164, 42): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (169, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (170, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (171, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (172, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (175, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (177, 25): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (194, 56): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/BcApiEntity.kt: (208, 25): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (254, 22): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (254, 22): Unsafe use of a nullable receiver of type JSONArray? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (262, 21): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (263, 27): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (264, 27): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (265, 16): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (272, 21): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (273, 27): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (274, 27): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/data/TravelRemoteDataSource.kt: (275, 16): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/content/travel/ui/adapter/ExploreVideoAdapterDelegate.kt: (74, 17): Unsafe use of a nullable receiver of type Date? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/logoman/data/LogoManNotificationRepo.kt: (58, 46): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/logoman/data/LogoManNotificationRepo.kt: (59, 46): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/logoman/data/LogoManNotificationRepo.kt: (60, 44): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/logoman/data/LogoManNotificationRepo.kt: (61, 42): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (9, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (57, 37): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (57, 55): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (108, 16): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (108, 34): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (203, 13): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/home/topsites/data/TopSitesRepo.kt: (203, 31): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/menu/HomeMenuDialog.kt: (270, 45): Elvis operator (?:) always returns the left operand of non-nullable type Context w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/msrp/data/MissionRemoteDataSource.kt: (85, 54): Type mismatch: inferred type is JSONArray? but JSONArray was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/msrp/data/MissionRemoteDataSource.kt: (90, 55): Type mismatch: inferred type is JSONObject? but JSONObject was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/msrp/data/MissionRemoteDataSource.kt: (171, 27): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/msrp/data/MissionRemoteDataSource.kt: (173, 56): Unsafe use of a nullable receiver of type JSONObject? w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (6, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (47, 20): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (47, 38): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (105, 43): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (107, 53): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (108, 52): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/periodic/FirstLaunchWorker.kt: (109, 54): Type mismatch: inferred type is Nothing? but String was expected w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesContentProvider.kt: (17, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesContentProvider.kt: (178, 13): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesContentProvider.kt: (178, 31): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesFactory.kt: (9, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesFactory.kt: (18, 13): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/preference/PreferencesFactory.kt: (18, 31): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/privately/PrivateMode.kt: (10, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/privately/PrivateMode.kt: (59, 13): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/privately/PrivateMode.kt: (59, 31): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/settings/defaultbrowser/data/DefaultBrowserLocalDataSource.kt: (4, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/settings/defaultbrowser/data/DefaultBrowserLocalDataSource.kt: (16, 13): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/settings/defaultbrowser/data/DefaultBrowserLocalDataSource.kt: (16, 31): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (5, 27): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (34, 9): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (34, 27): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (37, 29): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (37, 47): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (40, 9): 'PreferenceManager' is deprecated. Deprecated in Java w: /Users/jalmeida/src/FirefoxLite/app/src/main/java/org/mozilla/rocket/shopping/search/data/ShoppingSearchMode.kt: (40, 27): 'getDefaultSharedPreferences(Context!): SharedPreferences!' is deprecated. Deprecated in Java FAILURE: Build failed with an exception. ```