maxxcrawford
commented
2 years ago Is this spam? I do not have access to the Jira task linked above.
Open data-sync-user opened 2 years ago
maxxcrawford
commented
2 years ago Is this spam? I do not have access to the Jira task linked above.
Skip to content <#start-of-content> In this repository All GitHub ? Jump to ? No suggested jump to results In this repository All GitHub ? Jump to ? In this organization All GitHub ? Jump to ? In this repository All GitHub ? Jump to ? Dashboard Pullrequests Issues Marketplace Explore Codespaces Sponsors Settings @data-sync-user data-sync-user Sign out New repository Import repository New gist New organization @data-sync-user Sorry, something went wrong. {{ message }} / ... / mozilla / fx-private-relay-... / Clear Tip: Type # to search pull requests Type ? for help and tips Tip: Type # to search issues Type ? for help and tips Tip: Type # to search discussions Type ? for help and tips Tip: Type ! to search projects Type ? for help and tips Tip: Type @ to search teams Type ? for help and tips Tip: Type @ to search people and organizations Type ? for help and tips Tip: Type > to activate command mode Type ? for help and tips Tip: Go to your accessibility settings to change your keyboard shortcuts Type ? for help and tips Tip: Type author:@me to search your content Type ? for help and tips Tip: Type is:pr to filter to pull requests Type ? for help and tips Tip: Type is:issue to filter to issues Type ? for help and tips Tip: Type is:project to filter to projects Type ? for help and tips Tip: Type is:open to filter to open content Type ? for help and tips We’ve encountered an error and some results aren't available at this time. Type a new search or try again later. No results matched your search Top result Commands Type > to filter Global Commands Type > to filter This Page Files Pages Access Policies Organizations Repositories Issues, pull requests, and discussions Type # to filter Teams Users Projects Modes Use filters in issues, pull requests, discussions, and projects Search for issues and pull requests # Search for issues, pull requests, discussions, and projects # Search for organizations, repositories, and users @ Search for projects ! Search for files / Activate command mode > Search your issues, pull requests, and discussions # author:@me Search your issues, pull requests, and discussions # author:@me Filter to pull requests # is:pr Filter to issues # is:issue Filter to discussions # is:discussion Filter to projects # is:project Filter to open issues, pull requests, and discussions # is:open mozilla / fx
privaterelayaddon Public Unwatch Stop ignoring Watch 13 Notifications Participating and @mentions Only receive notifications from this repository when participating or @mentioned. All Activity Notified of all notifications on this repository. Ignore Never be notified. Custom Select events you want to be notified of in addition to participating and @mentions. Get push notifications on iOS or Android . Custom Custom Select events you want to be notified of in addition to participating and @mentions. Issues Pull requests Releases Discussions Security alerts Apply Cancel Fork 9 Unstar this repository? This will remove {{ repoNameWithOwner }} from the {{ listsWithCount }} that it's been added to. Unstar Starred 29 Star 29 Code Issues 158 Pull requests 10 Actions Projects 3 Wiki Security Insights More Code Issues Pull requests Actions Projects Wiki Security Insights Open in github.dev Open in a new github.dev tab Edit Code Checkout with GitHub CLI Work fast with our official CLI. Learn more . Checkout with GitHub Desktop Launching GitHub Desktop If nothing happens, download GitHub Desktop and try again. Launching GitHub Desktop If nothing happens, download GitHub Desktop and try again. Launching Xcode If nothing happens, download Xcode and try again. Launching Visual Studio Code Your codespace will open once ready. There was a problem preparing your codespace, please try again. Jump to bottom <#issue-comment-box> Fix #236 / MPP-1481: Show Correct Panel based on user's premium state #258 Save Cancel Merged maxxcrawford merged 1 commit into main from premium-panel-visibility on Jan 21 Merged Fix #236 / MPP-1481: Show Correct Panel based on user's premium state <#> #258 maxxcrawford merged 1 commit into main from premium-panel-visibility on Jan 21 +2 ?3 Conversation 5 Commits 1 Checks 3 Files changed 1 Conversation This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters Show hidden characters maxxcrawford ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Member @maxxcrawford maxxcrawford commented on Jan 19 <#issue-1108454752> Fixes #236 and MPP-1481 Summary: There was an issue where premium users who opened the panel would be presented with wrong panel/content. Fix: Removed |premiumCountryAvailability| check to show premium panel. If the user has already upgraded, we can infer their country/state is not an issue Testing Steps Have a premium account already created Run/open extension Log into premium account Open Panel Expected: The panel should include the stats dashboard (See screenshot) Screenshots Expected panel: image Sorry, something went wrong. @maxxcrawford |Fix #236 / MPP-1481: Removed premiumCountryAvailability check to show… | … Verified This commit was signed with the committer’s verified signature. maxxcrawford Maxx Crawford GPG key ID: 71DBD3273B65FEF9 Learn about vigilant mode . Loading status checks… |e3e71ac | … premium panel. If the user has already upgraded, we can infer their country/state is not an issue @maxxcrawford maxxcrawford requested review from Vinnl and codemist 4 months ago <#event-5919912316> codemist codemist approved these changes on Jan 19 <#pullrequestreview-857387914> View changes ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Collaborator @codemist codemist left a comment • edited Checked this branch out, works as expected ?? Sorry, something went wrong. maxxcrawford maxxcrawford reviewed on Jan 19 <#pullrequestreview-857468460> View changes src/js/popup/popup.js // Turned off label sync prompt for premium release // const shouldShowServerStoragePromptPanel = await serverStoragePanel.isRelevant(); // if (shouldShowServerStoragePromptPanel) { // serverStoragePanel.init(premium); // } else if (premium && premiumCountryAvailability?.premium_available_in_country === true) { ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Member Author @maxxcrawford maxxcrawford on Jan 19 <#discussion_r788225352> There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more . Hide comment @Vinnl Was there a specific use-case for limiting the premium panel to only Premium country-available users? Suggestion applied Commit suggestion Refresh and try again. Sorry, something went wrong. ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Collaborator @Vinnl Vinnl on Jan 20 <#discussion_r788534212> There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more . Hide comment tl;dr No, the country availability check can (and should) be removed. Looking at the PR that introduced it (#246 ), I simply went by the name of the function I replaced (|premiumFeaturesAvailable|) and replaced that with this check. Of course, whether the Premium feature flag was enabled is actually something different than whether Premium is available in the user's current country, and in this case, if the user already has Premium even if they're in a different country where Premium is not available, it should still be shown. Suggestion applied Commit suggestion Refresh and try again. Sorry, something went wrong. ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Collaborator @Vinnl Vinnl on Jan 20 <#discussion_r788535210> • edited There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more . Hide comment I just went over other instances of this check in |popup.js|, but those refer to the upgrade prompts ("Get unlimited aliases"), so this is the only one that should be removed :grinning: Suggestion applied Commit suggestion Refresh and try again. Sorry, something went wrong. ?? 1 maxxcrawford reacted with thumbs up emoji ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? Sorry, something went wrong. Quote reply Member Author @maxxcrawford maxxcrawford on Jan 21 <#discussion_r789850378> There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more . Hide comment @Vinnl Thanks for the background/double-check! Suggestion applied Commit suggestion Refresh and try again. Sorry, something went wrong. @data-sync-user Reply... Write Preview Add a suggestion, Add heading text Add bold text, Add italic text, Add a quote, Add code, Add a link, Add a bulleted list, Add a numbered list, Add a task list, Directly mention a user or team Reference an issue, pull request, or discussion Select a reply |ctrl . | Add saved reply There was an error creating your PullRequest. Attach files by dragging & dropping, selecting or pasting them. Uploading your files… We don’t support that file type. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. Attaching documents requires write permission to this repository. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. We don’t support that file type. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. This file is empty. Try again with a file that’s not empty. This file is hidden. Try again with another file. Something went really wrong, and we can’t process that file. Try again. Styling with Markdown is supported Nothing to preview Comment Cancel Resolve conversation Revert Hide details View details @maxxcrawford maxxcrawford merged commit |6ca5455| into main on Jan 21 3 checks passed @Vinnl Vinnl Restore branch deleted the premium-panel-visibility branch 3 months ago <#event-5933579569> @maxxcrawford maxxcrawford added the bug Something isn't working label on Jan 26 <#event-5960633258> @maxxcrawford maxxcrawford added this to the 2.2.1 milestone on Jan 26 <#event-5960635116> Hide environments Show environments This branch was successfully deployed 1 active deployment review — |e3e71ac2| Deployed on Jan 19 by github-actions[bot] Try again Couldn’t update branch Oops, something went wrong. @data-sync-user Write Preview Add heading text Add bold text, Add italic text, Add a quote, Add code, Insert Link Link Text URL Add Add a link, Add a bulleted list, Add a numbered list, Add a task list, Directly mention a user or team Reference an issue, pull request, or discussion Select a reply |ctrl . | Add saved reply Add heading text Add bold text, Add italic text, Add a bulleted list, Add a numbered list, Add a task list, There was an error creating your PullRequest. Attach files by dragging & dropping, selecting or pasting them. Uploading your files… We don’t support that file type. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. Attaching documents requires write permission to this repository. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. We don’t support that file type. Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TXT, XLS, XLSX or ZIP. This file is empty. Try again with a file that’s not empty. This file is hidden. Try again with another file. Something went really wrong, and we can’t process that file. Try again. Styling with Markdown is supported Nothing to preview Comment Remember, contributions to this repository should follow our GitHub Community Guidelines . ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers Request up to 100 reviewers You can only select 100 reviewers. Nothing to show Suggestions Everyone else @codemist codemist @Vinnl Vinnl Assignees Assign up to 10 people to this pull request You can only select 10 assignees. Nothing to show Suggestions No one—assign yourself Labels Apply labels to this pull request bug Something isn't working Projects Projects None yet Milestone Set milestone 2.2.1 Development Link an issue from this repository Successfully merging this pull request may close these issues. Free user addon menu displayed for premium user Notifications Customize Notification settings Loading... Subscribe You’re not receiving notifications from this thread. 3 participants @maxxcrawford @Vinnl @codemist Lock conversation Lock conversation on this pull request Other users can’t add new comments to this pull request. You and other members of teams with write access to this repository can still leave comments that others can see. You can always unlock this pull request again in the future. Reason for locking Optionally, choose a reason for locking that others can see. Learn more about when it’s appropriate to lock conversations . Lock conversation on this pull request Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. © 2022 GitHub, Inc. Terms Privacy Security Status Docs Contact GitHub Pricing API Training Blog * About You can’t perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.┆Issue is synchronized with this Jira Task