search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] getProcessStartTimeTicks crash #10434

Closed liuche closed 4 years ago

liuche commented 4 years ago

Crash in fenix.perf with getProcessStartTimeTicks in 5.0.0 release build.

Sentry log: https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/8293980/

┆Issue is synchronized with this Jira Task

liuche commented 4 years ago

@mcomella is this something from perf team telemetry?

mcarare commented 4 years ago

@liuche This seems to be a problem specific to using a privacy manager that relies on a hooking mechanism (SandHook) and it blocks reading the file in Stat.kt. The most we can do is catch the exception or maybe @mcomella has another idea. I do not think this crash will have a high recurrence.

mcomella commented 4 years ago

The most we can do is catch the exception or maybe @mcomella has another idea.

Yeah, I think we'll have to catch the exception.

This doesn't seem to have a high crash count and does seem to be related to OS customization so it doesn't urgent: I'll wait for triage later today to figure out the priority. This is probably a permacrash though and the fix is straightforward so I think we should address it, despite the low crash count.

liuche commented 4 years ago

This is with 1% rollout, but reasons seem good, I'll remove the RB label.