search

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
6.47k stars 1.27k forks source link

[Bug] shortcut icons issues #14315

Closed 532910 closed 1 year ago

532910 commented 4 years ago

Steps to reproduce

Creare shortcuts for https://github.com and https://online.raiffeisen.ru

Expected behavior

a better look for all icons

Actual behavior

raiffeisen icon is shown better on nightly: github icon is shown better on stable:

image

Device information

┆Issue is synchronized with this Jira Task

kbrosnan commented 4 years ago

@NotWoods looks like the manifest says the icon should be #ffffff https://online.raiffeisen.ru/import/favicons/manifest.json any idea what is going on here?

NotWoods commented 4 years ago

If a site doesn't provide a maskable icon, we guess the best background based on the image. We shifted from using a custom implementation to using the Android Palette API, so behaviour is slightly different.

I'm assuming "Stable" here is Fennec but I don't know for sure. What is the version in the about page for both stable and nightly?

liuche commented 4 years ago

The icon badging here look like Fenix-y icons (not fennec)

532910 commented 4 years ago

Stable is Fenix stable org.mozilla.firefox 79.0.5 from GPlay Nightly is Fenix nightly org.mozilla.fenix 200827 07:01

532910 commented 4 years ago

After several re-attempts I was able to create nice github icon on nightly and raiffeisen on stable.

532910 commented 4 years ago

imageimage

Looks like it depends on how completely page is loaded to the moment of shortcut creation.

532910 commented 4 years ago

And gitlab looks bad and the same every time

stale[bot] commented 3 years ago

See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

532910 commented 3 years ago

Gitlab icon still looks strange.

stale[bot] commented 2 years ago

See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

532910 commented 2 years ago

gitlab icon still looks bad

stale[bot] commented 1 year ago

See: https://github.com/mozilla-mobile/fenix/issues/17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

532910 commented 1 year ago

still actual

csadilek commented 1 year ago

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807105

Change performed by the Move to Bugzilla add-on.